Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753939AbZFQPxr (ORCPT ); Wed, 17 Jun 2009 11:53:47 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752226AbZFQPxj (ORCPT ); Wed, 17 Jun 2009 11:53:39 -0400 Received: from fg-out-1718.google.com ([72.14.220.152]:46954 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752041AbZFQPxi (ORCPT ); Wed, 17 Jun 2009 11:53:38 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=t5Yga/FnIod3IgF0cCo2F5xjRKXp8RNqr38V5bU2g6dfydDuIuaFz4J07cLMRv+HS7 nD1irKsYNF7BEOPRCGlIZFpSCX1OMzpnPtN4A4HFxwab8WujrkyuvetQpHgTgUOmuy2+ aLgebvdlY7NTAMoUuycArwNMHstnJ62I/qaGs= Date: Wed, 17 Jun 2009 19:53:37 +0400 From: Cyrill Gorcunov To: Vegard Nossum Cc: Ingo Molnar , LKML , Yinghai Lu Subject: Re: WARNING: at arch/x86/kernel/apic/apic.c:249 native_apic_write_dummy Message-ID: <20090617155337.GA10822@lenovo> References: <19f34abd0906170811h36a7082asf68294db9490a049@mail.gmail.com> <20090617151439.GC4675@lenovo> <19f34abd0906170846k2a1ab1e9q36f2a47852fbb8a4@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19f34abd0906170846k2a1ab1e9q36f2a47852fbb8a4@mail.gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1713 Lines: 52 [Vegard Nossum - Wed, Jun 17, 2009 at 05:46:18PM +0200] | 2009/6/17 Cyrill Gorcunov : | > [Vegard Nossum - Wed, Jun 17, 2009 at 05:11:20PM +0200] | > | Hi, | > | | > | I just saw this warning on latest mainline when shutting down a box: | [...] | | > Thanks Vegard, will take a look. | | I've attached full boot log (it's a different boot though). | | | Vegard ... Vegard, could you test the patch? -- Cyrill --- If we have apic disabled we don't even switch to APIC mode and do not calling for connect_bsp_APIC. Though on SMP compiled kernel the native_machine_shutdown does try to write the apic register anyway. Fix it with explicit check if we really should touch apic registers. Reported-by: Vegard Nossum Signed-off-by: Cyrill Gorcunov --- arch/x86/kernel/apic/io_apic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: linux-2.6.git/arch/x86/kernel/apic/io_apic.c ===================================================================== --- linux-2.6.git.orig/arch/x86/kernel/apic/io_apic.c +++ linux-2.6.git/arch/x86/kernel/apic/io_apic.c @@ -2003,7 +2003,9 @@ void disable_IO_APIC(void) /* * Use virtual wire A mode when interrupt remapping is enabled. */ - disconnect_bsp_APIC(!intr_remapping_enabled && ioapic_i8259.pin != -1); + if (cpu_has_apic) + disconnect_bsp_APIC(!intr_remapping_enabled && + ioapic_i8259.pin != -1); } #ifdef CONFIG_X86_32 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/