From: Frans Pop <elendil@planet.nl>
To: Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH]x86-tsc.c : fix compile warning
Date: Wed, 17 Jun 2009 18:12:49 +0200
User-Agent: KMail/1.9.9
Cc: Subrata Modak <subrata@linux.vnet.ibm.com>,
       "Figo.zhang" <figo1802@gmail.com>, lkml <linux-kernel@vger.kernel.org>,
       Sumit Panchasara <sumit.panchasara@einfochips.com>,
       "'Sachin P Sant'" <sachinp@linux.vnet.ibm.com>,
       "'H. Peter Anvin'" <hpa@zytor.com>,
       "'Andi Kleen'" <andi@firstfloor.org>,
       "'Thomas Gleixner'" <tglx@linutronix.de>,
       "'Balbir Singh'" <balbir@linux.vnet.ibm.com>,
       Jaswinder Singh Rajput <jaswinder@kernel.org>
References: <1245247057.3312.2.camel@myhost> <1245248241.4870.12.camel@subratamodak.linux.ibm.com> <20090617152802.GB6042@elte.hu>
In-Reply-To: <20090617152802.GB6042@elte.hu>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200906171812.51478.elendil@planet.nl>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 786
Lines: 21

On Wednesday 17 June 2009, Ingo Molnar wrote:
> Ah, and you fixed in what a superior way: you improved the code in
> the process :-) This is how warnings should be fixed really.

Hmm. Did you also see Pavel's reply to that patch [1]:
! But that's a bug to be fixed, I'd say? ... actually I believe you are
! introducing a bug here. Yes, old code would put random numbers in
! loops_per_jiffy_ref for !CPUFREQ_CONST_LOOPS, but you are introducing
! oops there.

Was his comment incorrect?

Cheers,
FJP

[1] http://lkml.org/lkml/2009/5/24/159
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/