Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757530AbZFQQz3 (ORCPT ); Wed, 17 Jun 2009 12:55:29 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754793AbZFQQzV (ORCPT ); Wed, 17 Jun 2009 12:55:21 -0400 Received: from e8.ny.us.ibm.com ([32.97.182.138]:46170 "EHLO e8.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754407AbZFQQzU (ORCPT ); Wed, 17 Jun 2009 12:55:20 -0400 Subject: Re: [PATCH]x86-tsc.c : fix compile warning From: Subrata Modak Reply-To: subrata@linux.vnet.ibm.com To: Ingo Molnar Cc: Frans Pop , "Figo.zhang" , lkml , Sumit Panchasara , "'Sachin P Sant'" , "'H. Peter Anvin'" , "'Andi Kleen'" , "'Thomas Gleixner'" , "'Balbir Singh'" , Jaswinder Singh Rajput In-Reply-To: <20090617162303.GA10158@elte.hu> References: <1245247057.3312.2.camel@myhost> <1245248241.4870.12.camel@subratamodak.linux.ibm.com> <20090617152802.GB6042@elte.hu> <200906171812.51478.elendil@planet.nl> <20090617162303.GA10158@elte.hu> Content-Type: text/plain Organization: IBM Date: Wed, 17 Jun 2009 22:25:13 +0530 Message-Id: <1245257714.6255.2.camel@subratamodak.linux.ibm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3 (2.12.3-8.el5_2.2) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1116 Lines: 38 On Wed, 2009-06-17 at 18:23 +0200, Ingo Molnar wrote: > * Frans Pop wrote: > > > On Wednesday 17 June 2009, Ingo Molnar wrote: > > > Ah, and you fixed in what a superior way: you improved the code in > > > the process :-) This is how warnings should be fixed really. > > > > Hmm. Did you also see Pavel's reply to that patch [1]: > > ! But that's a bug to be fixed, I'd say? ... actually I believe you are > > ! introducing a bug here. Yes, old code would put random numbers in > > ! loops_per_jiffy_ref for !CPUFREQ_CONST_LOOPS, but you are introducing > > ! oops there. > > > > Was his comment incorrect? > > > > Cheers, > > FJP > > > > [1] http://lkml.org/lkml/2009/5/24/159 > > hm, Pavel seems right - i missed that. Subrata, mind sending an > updated patch? Hmmm. I would try doing that soon. Regards-- Subrata > > Thanks, > > Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/