Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759609AbZFQUiN (ORCPT ); Wed, 17 Jun 2009 16:38:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754178AbZFQUh5 (ORCPT ); Wed, 17 Jun 2009 16:37:57 -0400 Received: from mail-gx0-f214.google.com ([209.85.217.214]:48339 "EHLO mail-gx0-f214.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753338AbZFQUh4 convert rfc822-to-8bit (ORCPT ); Wed, 17 Jun 2009 16:37:56 -0400 MIME-Version: 1.0 In-Reply-To: References: <20090611033705.20842.75501.sendpatchset@subratamodak.linux.ibm.com> <1245048719.5239.10.camel@subratamodak.linux.ibm.com> <1245243097.4870.3.camel@subratamodak.linux.ibm.com> <6E26D0A1-0FE5-4179-9DA8-FDF0E3D417DA@kernel.crashing.org> <20090617232341.c4543ff2.sfr@canb.auug.org.au> <20090617233452.03ac78d5.sfr@canb.auug.org.au> From: Grant Likely Date: Wed, 17 Jun 2009 14:37:38 -0600 Message-ID: Subject: Re: [PATCH][Resend 2][BUILD FAILURE 04/04] Next June 04:PPC64 randconfig [drivers/net/ucc_geth.o] To: Stephen Rothwell Cc: Kumar Gala , subrata@linux.vnet.ibm.com, netdev@vger.kernel.org, Li Yang , Nathan Lynch , Sachin P Sant , Linux-Next , Linux-Kernel , Balbir Singh , Linuxppc-dev , Tony Breeds , michael@ellerman.id.au, Haiying Wang , "David S. Miller" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2715 Lines: 63 On Wed, Jun 17, 2009 at 11:29 AM, Grant Likely wrote: > On Wed, Jun 17, 2009 at 7:34 AM, Stephen Rothwell wrote: >> On Wed, 17 Jun 2009 23:23:41 +1000 Stephen Rothwell wrote: >>> >>> Hi Kumar, >>> >>> On Wed, 17 Jun 2009 08:07:47 -0500 Kumar Gala wrote: >>> > >>> > >>> > I'm confused by the proposed fix as we already have *mdio & *ph >>> > defined in this function: >>> >>> Which tree are you looking at? ?Linus' tree, and linux-next, do not have >>> those local variables ... >> >> Hmmm, commit 0b9da337dca972e7a4144e298ec3adb8f244d4a4 ("net: Rework >> ucc_geth driver to use of_mdio infrastructure") removed the locals along >> with their usages, then commit 047584ce94108012288554a5f84585d792cc7f8f >> ("net/ucc_geth: Add SGMII support for UEC GETH driver") added more uses >> without adding the variables back. >> >> Here is the patch again: >> >> From: Subrata Modak >> Subject: [PATCH] Fix build error in ucc_geth.c >> >> Fix the following build error: >> >> drivers/net/ucc_geth.c: In function bucc_geth_probeb: >> drivers/net/ucc_geth.c:3822: error: 'ph' undeclared (first use in this function) >> drivers/net/ucc_geth.c:3822: error: (Each undeclared identifier is reported only once >> drivers/net/ucc_geth.c:3822: error: for each function it appears in.) >> drivers/net/ucc_geth.c:3832: error: 'mdio' undeclared (first use in this function) >> make[2]: *** [drivers/net/ucc_geth.o] Error 1 >> >> Signed-off-by: Subrata Modak >> >> --- linux-2.6.30-rc8/drivers/net/ucc_geth.c.orig ? ? ? ?2009-06-10 11:58:39.000000000 -0500 >> +++ linux-2.6.30-rc8/drivers/net/ucc_geth.c ? ? 2009-06-10 22:28:13.000000000 -0500 >> @@ -3595,6 +3595,8 @@ static const struct net_device_ops ucc_g >> >> ?static int ucc_geth_probe(struct of_device* ofdev, const struct of_device_id *match) >> ?{ >> + ? ? ? struct device_node *mdio; >> + ? ? ? const phandle *ph; >> ? ? ? ?struct device *device = &ofdev->dev; >> ? ? ? ?struct device_node *np = ofdev->node; >> ? ? ? ?struct net_device *dev = NULL; > > Ah, this might not be the right fix then. ?I'll look. Yeah, this is not the right fix. The SGMII change doesn't mesh well with the of_mdio changes and needed some rewriting. I'm about to post a patch (compile tested only) which should make things happy. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/