Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762509AbZFRLw6 (ORCPT ); Thu, 18 Jun 2009 07:52:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1761627AbZFRLwu (ORCPT ); Thu, 18 Jun 2009 07:52:50 -0400 Received: from smtprelay04.ispgateway.de ([80.67.18.16]:42306 "EHLO smtprelay04.ispgateway.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760386AbZFRLwu (ORCPT ); Thu, 18 Jun 2009 07:52:50 -0400 References: <20090604211103.4214303f.peter@piie.net> <20090616060107.GA4752@liondog.tnic> <200906160747.04094.edt@aei.ca> <20090616205747.GA6356@rhlx01.hs-esslingen.de> <20090617001435.e2d86780.peter@piie.net> <20090617122022.GA13141@rhlx01.hs-esslingen.de> <9ea470500906180329w7c8975b0ra60fa219221d53f6@mail.gmail.com> <9ea470500906180442r7beb49a8odcb3bf602df78b47@mail.gmail.com> Message-ID: X-Mailer: http://www.courier-mta.org/cone/ From: Peter Feuerer To: Borislav Petkov Cc: Andreas Mohr , Ed Tomlinson , akpm@linux-foundation.org, Len Brown , Matthew Garrett , LKML Subject: Re: [PATCH] Request driver inclusion - acer aspire one fan control Date: Thu, 18 Jun 2009 13:49:30 +0200 Mime-Version: 1.0 Content-Type: text/plain; format=flowed; charset="US-ASCII" Content-Disposition: inline Content-Transfer-Encoding: 7bit X-Df-Sender: 404094 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2796 Lines: 74 Hi, Borislav Petkov writes: > Hi, > > On Thu, Jun 18, 2009 at 12:55 PM, Peter Feuerer wrote: >>>>> Didn't someone argue that pre_suspend_kernelmode was unnecessary? >>>>> It's still in there. (could be submitted together with the >>>>> Kconfig ACPI depends ;) >>>> >>>> Actually I think pre_suspend_kernelmode is needed, so it won't be >>>> dropped. >>> >>> and it is needed, because...? >> >> It's needed because we do now a clean revert to bios mode before we suspend. >> And after resume we have to switch to kernelmode again, if the driver was in >> kernelmode before suspend. So we need to keep track of in what state the >> driver was before suspending. That's what's this variable is for. > > You've got that state in the 'kernelmode' variable. See full comment: > http://marc.info/?l=linux-kernel&m=124482114200865 We are talking about patch 0.5.9 and not 0.5.8, are we? http://patchwork.kernel.org/patch/30733/mbox/ have a look at at line 543: + /* remember previous setting */ + pre_suspend_kernelmode = kernelmode; + + if (kernelmode) { + acerhdf_revert_to_bios_mode(); + if (acerhdf_thz_dev) + thermal_zone_device_update(acerhdf_thz_dev); + } o we save the kernelmode to pre_suspend_kernelmode o then if kernelmode is on, we call acerhdf_revert_to_bios_mode() o we start a thermal_zone_device_update which let the thermal layer call acerhdf_set_cur_state o acerhdf_set_cur_state then disables kernelmode (and sets kernelmode = 0) so we would lose the state of the kernelmode if we didn't save it within pre_suspend_kernelmode > >>>> I'll add the ACPI dependency to Kconfig and submit the patch to lkml >>>> and directly to Linus, as Len doesn't seem to react?! - Boris what do >>>> you think? I mean, even if there's a problem with suspend / resume, >>>> this can also be fixed after the merge window, while all those release >>>> candidates are done. >>> >>> Nope, this has to be fixed before submission. The merge window is open, >>> I think, until mid next week so there's plenty of time. >> >> I'll be only there until Sunday evening. I'm going to be on business trip >> starting on Monday (and returning probably at Saturday). But I'll do my best >> to figure out the problem. >> >> I wasn't able to reproduce the suspend / resume problem Andreas has with >> acerhdf 0.5.9 yesterday and the day before. Do you also have the problem, >> that acerhdf is reading sometimes an unexpected Fan state after resuming? > > Will look into it on the weekend. Great! Thank you very much! regards, --peter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/