Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764209AbZFROIW (ORCPT ); Thu, 18 Jun 2009 10:08:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1763380AbZFROIJ (ORCPT ); Thu, 18 Jun 2009 10:08:09 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:53162 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762117AbZFROII (ORCPT ); Thu, 18 Jun 2009 10:08:08 -0400 Date: Thu, 18 Jun 2009 10:08:02 -0400 From: Neil Horman To: Steven Rostedt Cc: Xiao Guangrong , Ingo Molnar , Frederic Weisbecker , LKML , netdev@vger.kernel.org, David Miller Subject: Re: [PATCH v2] ftrace: change the export format of trace_kfree_skb() Message-ID: <20090618140802.GA10300@hmsreliant.think-freely.org> References: <4A2DF91F.7030906@cn.fujitsu.com> <20090609182730.GA6057@nowhere> <4A2F0F1D.7010101@cn.fujitsu.com> <20090610072618.GA6016@nowhere> <4A39B3E4.6060004@cn.fujitsu.com> <20090618103538.GA8978@hmsreliant.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-Spam-Score: -1.4 (-) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1435 Lines: 42 On Thu, Jun 18, 2009 at 08:51:12AM -0400, Steven Rostedt wrote: > > On Thu, 18 Jun 2009, Neil Horman wrote: > > > > > > diff --git a/include/trace/events/skb.h b/include/trace/events/skb.h > > > index 1e8fabb..2496060 100644 > > > --- a/include/trace/events/skb.h > > > +++ b/include/trace/events/skb.h > > > @@ -7,6 +7,71 @@ > > > #undef TRACE_SYSTEM > > > #define TRACE_SYSTEM skb > > > > > > +#define protocol_name(protocol) { protocol, #protocol } > > > +#define show_protocol_name(val) \ > > > + __print_symbolic(val, \ > > > > Don't you need to include ftrace.h to pull in the __print_symbolic definition? > > Or is that always guaranteed to be included from tracepoint.h? > > Its use is in one of the fields of TRACE_EVENT that are only used by > define_trace.h. All other users will ignore it. > > #define TRACE_EVENT(name, proto, args, struct, assign, print) \ > DECLARE_TRACE(name, PARAMS(proto), PARAMS(args)) > > Only name, proto, args is used. The define_trace.h will include > trace/ftrace.h and that will use the struct, assign and print args. > > So the answer is "no" ;-) > > -- Steve > > Ok, thanks Acked-by: Neil Horman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/