Date: Thu, 18 Jun 2009 12:00:34 -0700 (PDT)
Message-Id: <20090618.120034.246557840.davem@davemloft.net>
To: rientjes@google.com
Cc: eric.dumazet@gmail.com, jpiszcz@lucidpixels.com,
       linux-kernel@vger.kernel.org
Subject: Re: [patch] ipv4: don't warn about skb ack allocation failures
From: David Miller <davem@davemloft.net>
In-Reply-To: <alpine.DEB.2.00.0906180935130.2894@chino.kir.corp.google.com>
References: <4A396EA2.60705@gmail.com>
	<20090617.160840.58571632.davem@davemloft.net>
	<alpine.DEB.2.00.0906180935130.2894@chino.kir.corp.google.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1021
Lines: 22

From: David Rientjes <rientjes@google.com>
Date: Thu, 18 Jun 2009 09:56:14 -0700 (PDT)

> I disagree, page allocation failure messages show vital information about 
> the state of the VM so that we can find bugs and GFP_ATOMIC allocations 
> are the most common trigger for these diagnostic messages since 
> __GFP_WAIT allocations can trigger direct reclaim (and __GFP_FS 
> allocations can trigger the oom killer) to free memory and will retry the 
> allocation if ~__GFP_NORETRY.

It's COMPLETELY and ABSOLUTELY normal for GFP_ATOMIC allocations to
fail in the networking.

If you warn it will just spam the logs, and on a router forwarding
millions of packets per second are you sure that can ever be sane?

Use statistics and tracing if necessary, but log spam no way...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/