Date: Thu, 18 Jun 2009 22:11:25 -0400 (EDT)
From: Steven Rostedt <rostedt@goodmis.org>
To: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
cc: Ingo Molnar <mingo@elte.hu>, Frederic Weisbecker <fweisbec@gmail.com>,
       LKML <linux-kernel@vger.kernel.org>, netdev@vger.kernel.org,
       David Miller <davem@davemloft.net>, Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [PATCH v2] ftrace: change the export format of
 trace_kfree_skb()
In-Reply-To: <4A3AF273.6010502@cn.fujitsu.com>
Message-ID: <alpine.DEB.2.00.0906182210560.6890@gandalf.stny.rr.com>
References: <4A2DF91F.7030906@cn.fujitsu.com> <20090609182730.GA6057@nowhere> <4A2F0F1D.7010101@cn.fujitsu.com> <20090610072618.GA6016@nowhere> <4A39B3E4.6060004@cn.fujitsu.com> <alpine.DEB.2.00.0906182033101.6890@gandalf.stny.rr.com>
 <4A3AF273.6010502@cn.fujitsu.com>
User-Agent: Alpine 2.00 (DEB 1167 2008-08-23)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1671
Lines: 46


On Fri, 19 Jun 2009, Xiao Guangrong wrote:

> 
> 
> Steven Rostedt wrote:
> 
> >> Changelog v1->v2:
> >> Convert protocol from raw numeric to its name as Frederic's suggestion
> >>
> >> Signed-off-by: Xiao Guangrong <xiaoguangrong@cn.fujitsu.com>
> >> Acked-by: Frederic Weisbecker <fweisbec@gmail.com>
> > 
> > I get this:
> > 
> >   CC      net/core/net-traces.o
> > In file included from include/trace/ftrace.h:262,
> >                  from include/trace/define_trace.h:57,
> >                  from include/trace/events/skb.h:107,
> >                  from net/core/net-traces.c:28:
> > include/trace/events/skb.h: In function 'ftrace_raw_output_kfree_skb':
> > include/trace/events/skb.h:78: error: 'ETH_P_IEEE802154' undeclared (first 
> > use in this function)
> > include/trace/events/skb.h:78: error: (Each undeclared identifier is 
> > reported only once
> > include/trace/events/skb.h:78: error: for each function it appears in.)
> > 
> 
> I use Ingo's tip tree and this build error not occur in my test, I also find
> ETH_P_IEEE802154 is added by Sergey Lapin's patch, it's merged recently, can
> be found here:
> 	http://marc.info/?l=git-commits-head&m=124515655608598&w=2
> 
> Could you check ETH_P_IEEE802154 is defined in include/linux/if_ether.h and
> your code is the latest?

Hmm, I just work with the tracing/* branches. If this depends on another 
branch, then I'll let Ingo take care of it.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/