Date: Fri, 19 Jun 2009 09:51:48 +0200
From: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
To: David Brownell <david-b@pacbell.net>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>, linux-usb@vger.kernel.org,
       avictor.za@gmail.com, linux-kernel@vger.kernel.org,
       patrice.vilchez@atmel.com
Subject: Re: [PATCH 2/2] at91/USB: at91sam9g45 series USB host integration
Message-ID: <20090619095148.67a74ed9@hskinnemoen-d830>
In-Reply-To: <200906190043.00428.david-b@pacbell.net>
References: <1244547493-19654-1-git-send-email-nicolas.ferre@atmel.com>
	<1244547493-19654-2-git-send-email-nicolas.ferre@atmel.com>
	<1244547493-19654-3-git-send-email-nicolas.ferre@atmel.com>
	<200906190043.00428.david-b@pacbell.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1099
Lines: 29

David Brownell wrote:
> > --- a/arch/arm/mach-at91/at91sam9g45_devices.c
> > +++ b/arch/arm/mach-at91/at91sam9g45_devices.c

> > +	/* Enable VBus control for UHP ports */
> > +	for (i = 0; i < data->ports; i++) {
> > +		if (data->vbus_pin[i])
> > +			at91_set_gpio_output(data->vbus_pin[i], 0);  
> 
> This should gpio_request() and gpio_direction_output().

Hmm...I thought the driver was supposed to call gpio_request(), not the
platform code?

> Don't use AT91-specific GPIO calls except for things that
> the generic calls don't support ... like enabling open-drain
> outputs, the deglitching support, or input pullups.

This call does port configuration, which you convinced me a long time
ago was a fundamentally different thing from GPIO. If the pin really
requires one of those features, this would definitely be the place to
set it up.

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/