DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=rgrZ5VEHd1pPAO46yH7hJPhnjgBlf0k7exDkBFXBuZ9Fldx632gNAvdqYQploFAfLTWrNOoSiUZydC6+NwWkAix5vbpVvC+WPVCi5tpMcGgDGBu41eY3VD9EtD58o4i0O8YrdjjxPfhRZgk/h3TeP3me98wAeMiaz8Y2ynqMF0A=  ;
From: David Brownell <david-b@pacbell.net>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Subject: Re: [PATCH 1/2 v2] at91/USB: Add USB drivers for at91sam9g45 series
Date: Fri, 19 Jun 2009 00:54:16 -0700
User-Agent: KMail/1.9.10
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
       haavard.skinnemoen@atmel.com, patrice.vilchez@atmel.com
References: <1244720355-10740-1-git-send-email-nicolas.ferre@atmel.com>
In-Reply-To: <1244720355-10740-1-git-send-email-nicolas.ferre@atmel.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 8bit
Content-Disposition: inline
Message-Id: <200906190054.16418.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 858
Lines: 21

On Thursday 11 June 2009, Nicolas Ferre wrote:
> --- a/drivers/usb/host/ohci-at91.c
> +++ b/drivers/usb/host/ohci-at91.c

Again, please split this out:  OHCI patches separate from EHCI.


> @@ -148,7 +148,8 @@ static int usb_hcd_at91_probe(const struct hc_driver
> *driver, at91_start_hc(pdev);
> ????????ohci_hcd_init(hcd_to_ohci(hcd));
> ?
> -???????retval = usb_add_hcd(hcd, pdev->resource[1].start, IRQF_DISABLED);
> +???????retval = usb_add_hcd(hcd, pdev->resource[1].start,
> +???????????????????????????????IRQF_DISABLED | IRQF_SHARED);

Just pass IRQF_SHARED.  That combination is not going be effective.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/