DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws;
  s=s1024; d=pacbell.net;
  h=Received:X-YMail-OSG:X-Yahoo-Newman-Property:From:To:Subject:Date:User-Agent:Cc:References:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding:Content-Disposition:Message-Id;
  b=wfQChZG6jiKpsJ7F6elrLFQszHVGX8LlzSsBupSKFMFN6MSRgk5/Q9W94sQZAHFXZxwk9Riiky0MNXFh7FSZT3Aa+Hf7H/qcyZZnXecQCmSKJFEYdpl5rohfSwF9/hJDWXNfghKj6NLvjiK+1aLpZ4IQ2DEN2gSqY6+6T6kdwCE=  ;
From: David Brownell <david-b@pacbell.net>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Subject: Re: [PATCH 1/2 v2] at91/USB: Add USB drivers for at91sam9g45 series
Date: Fri, 19 Jun 2009 00:59:51 -0700
User-Agent: KMail/1.9.10
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
       haavard.skinnemoen@atmel.com, patrice.vilchez@atmel.com
References: <1244720355-10740-1-git-send-email-nicolas.ferre@atmel.com>
In-Reply-To: <1244720355-10740-1-git-send-email-nicolas.ferre@atmel.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200906190059.51576.david-b@pacbell.net>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1387
Lines: 32

On Thursday 11 June 2009, Nicolas Ferre wrote:
> Add both host and gadget USB drivers for at91sam9g45 series. Those SOC embed
> high speed USB interfaces.
> The gadget driver is the already available atmel_usba_udc.
> The host driver is an EHCI with its companion OHCI. EHCI is handled by the new
> ehci-atmel.c whereas the OHCI is always handled by ohci-at91.c. This last
> wrapper is modified to allow IRQ sharing between two controllers.
> 
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>

Talking only about the EHCI bits here ... it looks pretty generic
except for the clock management, which can't be.

The tricky bits here will be system suspend/resume support, with
the host controller able to trigger remote wakeup.  Clearly you
don't support system suspend/resume yet.

A slightly less tricky bit would be suspending the root hub.
Sometimes the hardware needs help there; other times it can
automatically gate the various clocks and save power.

If you split out patches for each of the drivers, I can ack
each of those seaprately.  And then hope to see patches which
add power management support before too long.

- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/