Date: Fri, 19 Jun 2009 10:13:23 +0100
From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Roland McGrath <roland@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/17] arm: arch_ptrace clean-up
Message-ID: <20090619091323.GA18246@flint.arm.linux.org.uk>
References: <20090425000634.313E4FC3C8@magilla.sf.frob.com> <20090425000732.ACB87FC3C8@magilla.sf.frob.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090425000732.ACB87FC3C8@magilla.sf.frob.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 964
Lines: 22

On Fri, Apr 24, 2009 at 05:07:32PM -0700, Roland McGrath wrote:
> This cleans up arch_ptrace() on arm to use the generic ptrace_request()
> for everything it can.  This gets rid of the non-arch ptrace internals
> magic from the arch code.

It also changes the semantics a bit, and I don't buy the "it doesn't
matter" comments, especially in the PT_SINGLESTEP case.  Having
PT_SINGLESTEP set the flag but later fail is not nice behaviour at all,
it means that, despite the ptrace call failing, the next time that the
task encounters a signal, it will enter single stepping mode.

Therefore, I believe this patch is wrong.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/