Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754925AbZFSRmU (ORCPT ); Fri, 19 Jun 2009 13:42:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753169AbZFSRmG (ORCPT ); Fri, 19 Jun 2009 13:42:06 -0400 Received: from rcsinet11.oracle.com ([148.87.113.123]:41297 "EHLO rgminet11.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751084AbZFSRmE (ORCPT ); Fri, 19 Jun 2009 13:42:04 -0400 Message-ID: <4A3BCD0D.3010801@oracle.com> Date: Fri, 19 Jun 2009 10:38:21 -0700 From: Randy Dunlap Organization: Oracle Linux Engineering User-Agent: Thunderbird 2.0.0.6 (X11/20070801) MIME-Version: 1.0 To: Stephen Rothwell CC: linux-next@vger.kernel.org, LKML , Jonathan Brassow , dm-devel@redhat.com, Andrew Morton Subject: [PATCH -next] dm: dm-log-userspace depends on NET References: <20090619172622.05adb236.sfr@canb.auug.org.au> In-Reply-To: <20090619172622.05adb236.sfr@canb.auug.org.au> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Source-IP: abhmt008.oracle.com [141.146.116.17] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A010203.4A3BCDCB.02B1:SCFSTAT5015188,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1731 Lines: 46 From: Randy Dunlap DM_LOG_USERSPACE selects CONNECTOR, but when NET is not enabled, this is useless and the build fails, so make DM_LOG_USERSPACE depend on NET. ERROR: "netlink_has_listeners" [drivers/connector/cn.ko] undefined! ERROR: "proc_net_fops_create" [drivers/connector/cn.ko] undefined! ERROR: "netlink_kernel_create" [drivers/connector/cn.ko] undefined! ERROR: "proc_net_remove" [drivers/connector/cn.ko] undefined! ERROR: "netlink_kernel_release" [drivers/connector/cn.ko] undefined! ERROR: "init_net" [drivers/connector/cn.ko] undefined! ERROR: "__alloc_skb" [drivers/connector/cn.ko] undefined! ERROR: "netlink_broadcast" [drivers/connector/cn.ko] undefined! ERROR: "kfree_skb" [drivers/connector/cn.ko] undefined! ERROR: "skb_put" [drivers/connector/cn.ko] undefined! Signed-off-by: Randy Dunlap Cc: Jonathan Brassow Cc: dm-devel@redhat.com --- drivers/md/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20090619.orig/drivers/md/Kconfig +++ linux-next-20090619/drivers/md/Kconfig @@ -233,7 +233,7 @@ config DM_MIRROR config DM_LOG_USERSPACE tristate "Mirror userspace logging (EXPERIMENTAL)" - depends on DM_MIRROR && EXPERIMENTAL + depends on DM_MIRROR && EXPERIMENTAL && NET select CONNECTOR ---help--- The userspace logging module provides a mechanism for -- ~Randy LPC 2009, Sept. 23-25, Portland, Oregon http://linuxplumbersconf.org/2009/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/