Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752795AbZFSTqD (ORCPT ); Fri, 19 Jun 2009 15:46:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751957AbZFSTpz (ORCPT ); Fri, 19 Jun 2009 15:45:55 -0400 Received: from smtp-out.google.com ([216.239.33.17]:56144 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751575AbZFSTpz (ORCPT ); Fri, 19 Jun 2009 15:45:55 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id: references:user-agent:mime-version:content-type:x-system-of-record; b=bn3GbvvLmyrKd6q8jqBdXxTohxZuBVsaTVsqCYsU7OwLcb6WuwyBLi6/0dkguuDWZ D1jKabIUvWh+269Nd3nEQ== Date: Fri, 19 Jun 2009 12:45:50 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: David Miller cc: eric.dumazet@gmail.com, jpiszcz@lucidpixels.com, linux-kernel@vger.kernel.org Subject: Re: [patch] ipv4: don't warn about skb ack allocation failures In-Reply-To: <20090618.123708.78849607.davem@davemloft.net> Message-ID: References: <20090618.120034.246557840.davem@davemloft.net> <20090618.123708.78849607.davem@davemloft.net> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 681 Lines: 17 On Thu, 18 Jun 2009, David Miller wrote: > > I understand what you're trying to avoid, but I disagree with the > > approach of altering the default behavior of GFP_ATOMIC. > > The default got changed at some point because it never did > crap like this before. > Wrong, the page allocator has warned about page allocation failures when __GFP_NOWARN was not specified since 2.5.53. __GFP_NOWARN was never a default for GFP_ATOMIC. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/