Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761386AbZFSWi7 (ORCPT ); Fri, 19 Jun 2009 18:38:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760994AbZFSWhX (ORCPT ); Fri, 19 Jun 2009 18:37:23 -0400 Received: from smtp-out.google.com ([216.239.45.13]:8619 "EHLO smtp-out.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760972AbZFSWhV (ORCPT ); Fri, 19 Jun 2009 18:37:21 -0400 DomainKey-Signature: a=rsa-sha1; s=beta; d=google.com; c=nofws; q=dns; h=date:from:x-x-sender:to:cc:subject:in-reply-to:message-id: references:user-agent:mime-version:content-type:x-system-of-record; b=hrNPi2XM8+C2m4Mx38brxoybl1BaJYAMFZDryjb9Nrs9Wi0eaWrOA7cnJMU9+To0i X1x3JxIaqZRQEw1c944Tw== Date: Fri, 19 Jun 2009 15:37:17 -0700 (PDT) From: David Rientjes X-X-Sender: rientjes@chino.kir.corp.google.com To: "Eric W. Biederman" cc: David Miller , eric.dumazet@gmail.com, jpiszcz@lucidpixels.com, linux-kernel@vger.kernel.org Subject: Re: [patch] ipv4: don't warn about skb ack allocation failures In-Reply-To: Message-ID: References: <20090618.120034.246557840.davem@davemloft.net> <20090618.123708.78849607.davem@davemloft.net> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-System-Of-Record: true Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1412 Lines: 30 On Fri, 19 Jun 2009, Eric W. Biederman wrote: > But Mr. Reintjes if you really want the traces I can set up > an script to email them to you every time it happens. Say about > 1 a minute from my paltry little farm of machines. > Perhaps you missed my email where I suggested emitting the page allocation warnings only when CONFIG_DEBUG_VM is enabled. It's at http://lkml.org/lkml/2009/6/18/355. We can then keep the __GFP_NOFAIL flag to indicate that the warnings should never be emitted for that allocation, regardless of the .config. It's funny, though, that the problem that originally started this thread was quickly diagnosed because of these messages. As far as I know, my suggestion to increase /proc/sys/vm/dirty_background_ratio to kick pdflush earlier has prevented the slab allocation failures and not required delayed acks for nfsd. That was possible because of the page allocation failure messages that were noticed by the user; without this evidence, the only symptom would have been extremely slow I/O over nfs. This could involve any number of subsystems and I doubt the first reaction would have been to enable CONFIG_DEBUG_VM. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/