Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758274AbZFSXEd (ORCPT ); Fri, 19 Jun 2009 19:04:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752355AbZFSXEZ (ORCPT ); Fri, 19 Jun 2009 19:04:25 -0400 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:42046 "EHLO sunset.davemloft.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751948AbZFSXEZ (ORCPT ); Fri, 19 Jun 2009 19:04:25 -0400 Date: Fri, 19 Jun 2009 16:04:29 -0700 (PDT) Message-Id: <20090619.160429.52033928.davem@davemloft.net> To: rientjes@google.com Cc: ebiederm@xmission.com, eric.dumazet@gmail.com, jpiszcz@lucidpixels.com, linux-kernel@vger.kernel.org Subject: Re: [patch] ipv4: don't warn about skb ack allocation failures From: David Miller In-Reply-To: References: <20090618.123708.78849607.davem@davemloft.net> X-Mailer: Mew version 6.2.51 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 704 Lines: 18 From: David Rientjes Date: Fri, 19 Jun 2009 15:37:17 -0700 (PDT) > That was possible because of the page allocation failure messages that > were noticed by the user; without this evidence, the only symptom would > have been extremely slow I/O over nfs. That's garbage. With tracing and statistics you could have noticed it too. Just because the notification is more annoying and in your face, does not mean it's implicitly better. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/