Date: Sat, 20 Jun 2009 10:21:01 +0200
From: Jean Delvare <khali@linux-fr.org>
To: "Hans J. Koch" <hjk@linutronix.de>, Jiri Slaby <jirislaby@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
       lm-sensors@lm-sensors.org
Subject: Re: [lm-sensors] [PATCH 1/1] HWMON: max6650, fix lock imbalance
Message-ID: <20090620102101.35e92c01@hyperion.delvare>
In-Reply-To: <20090619230252.GB3862@local>
References: <1245446795-1901-1-git-send-email-jirislaby@gmail.com>
	<20090619230252.GB3862@local>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1173
Lines: 37

On Sat, 20 Jun 2009 01:02:52 +0200, Hans J. Koch wrote:
> On Fri, Jun 19, 2009 at 11:26:35PM +0200, Jiri Slaby wrote:
> > Add omitted update_lock to one switch/case in set_div.
> 
> Ahem, yes, thanks!
> 
> > 
> > Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
> 
> Signed-off-by: Hans J. Koch <hjk@linutronix.de>
> 
> > ---
> >  drivers/hwmon/max6650.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/hwmon/max6650.c b/drivers/hwmon/max6650.c
> > index 86142a8..58f66be 100644
> > --- a/drivers/hwmon/max6650.c
> > +++ b/drivers/hwmon/max6650.c
> > @@ -418,6 +418,7 @@ static ssize_t set_div(struct device *dev, struct device_attribute *devattr,
> >  		data->count = 3;
> >  		break;
> >  	default:
> > +		mutex_unlock(&data->update_lock);
> >  		dev_err(&client->dev,
> >  			"illegal value for fan divider (%d)\n", div);
> >  		return -EINVAL;

Applied, thanks.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/