Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752077AbZFUNqq (ORCPT ); Sun, 21 Jun 2009 09:46:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751332AbZFUNqh (ORCPT ); Sun, 21 Jun 2009 09:46:37 -0400 Received: from rhun.apana.org.au ([64.62.148.172]:41723 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751259AbZFUNqh (ORCPT ); Sun, 21 Jun 2009 09:46:37 -0400 Date: Sun, 21 Jun 2009 21:46:35 +0800 From: Herbert Xu To: Huang Ying Cc: linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: [RFC 2/7] crypto: Use GHASH digest algorithm in GCM Message-ID: <20090621134635.GA2980@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1244704228.5320.125.camel@yhuang-dev.sh.intel.com> Organization: Core X-Newsgroups: apana.lists.os.linux.cryptoapi,apana.lists.os.linux.kernel User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 759 Lines: 20 Huang Ying wrote: > > + ghash = crypto_alloc_ahash("ghash", 0, 0); > + if (IS_ERR(ghash)) > + return PTR_ERR(ghash); We should add this as an extra parameter to gcm_base. This is so that the user can select an alternative ghash implementation. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/