Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755189AbZFVClW (ORCPT ); Sun, 21 Jun 2009 22:41:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752894AbZFVClP (ORCPT ); Sun, 21 Jun 2009 22:41:15 -0400 Received: from fgwmail5.fujitsu.co.jp ([192.51.44.35]:35933 "EHLO fgwmail5.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752742AbZFVClO (ORCPT ); Sun, 21 Jun 2009 22:41:14 -0400 Date: Mon, 22 Jun 2009 11:39:53 +0900 (JST) From: KOSAKI Motohiro To: Jiri Slaby Subject: Re: BUG: Bad page state [was: Strange oopses in 2.6.30] Cc: kosaki.motohiro@jp.fujitsu.com, Maxim Levitsky , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mel Gorman , Andrew Morton , Lee Schermerhorn , Christoph Lameter , Pekka Enberg In-Reply-To: <4A3CFFEC.1000805@gmail.com> References: <1245506908.6327.36.camel@localhost> <4A3CFFEC.1000805@gmail.com> Message-Id: <20090622113652.21E7.A69D9226@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.50.07 [ja] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1174 Lines: 40 (cc to Mel and some reviewer) > Flags are: > 0000000000400000 -- __PG_MLOCKED > 800000000050000c -- my page flags > 3650000c -- Maxim's page flags > 0000000000693ce1 -- my PAGE_FLAGS_CHECK_AT_FREE I guess commit da456f14d (page allocator: do not disable interrupts in free_page_mlock()) is a bit wrong. current code is: ------------------------------------------------------------- static void free_hot_cold_page(struct page *page, int cold) { (snip) int clearMlocked = PageMlocked(page); (snip) if (free_pages_check(page)) return; (snip) local_irq_save(flags); if (unlikely(clearMlocked)) free_page_mlock(page); ------------------------------------------------------------- Oh well, we remove PG_Mlocked *after* free_pages_check(). Then, it makes false-positive warning. Sorry, my review was also wrong. I think reverting this patch is better ;) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/