Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752788AbZFVOgX (ORCPT ); Mon, 22 Jun 2009 10:36:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752871AbZFVOgM (ORCPT ); Mon, 22 Jun 2009 10:36:12 -0400 Received: from palinux.external.hp.com ([192.25.206.14]:49648 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751907AbZFVOgL (ORCPT ); Mon, 22 Jun 2009 10:36:11 -0400 Date: Mon, 22 Jun 2009 08:36:13 -0600 From: Matthew Wilcox To: Ralf Baechle Cc: Alex Chiang , jbarnes@virtuousgeek.org, linux-arch@vger.kernel.org, Kyle McMartin , Tony Luck , Russell King , Arnd Bergmann , Yoshinori Sato , Benjamin Herrenschmidt , Jeff Dike , linux-kernel@vger.kernel.org, David Howells , Paul Mundt , Ivan Kokshaysky , Ingo Molnar , "David S. Miller" Subject: Re: [PATCH] PCI: remove pcibios_scan_all_fns() Message-ID: <20090622143613.GU19977@parisc-linux.org> References: <20090622140807.25509.54448.stgit@bob.kio> <20090622142602.GA25289@linux-mips.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090622142602.GA25289@linux-mips.org> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1031 Lines: 23 On Mon, Jun 22, 2009 at 03:26:02PM +0100, Ralf Baechle wrote: > On Mon, Jun 22, 2009 at 08:08:07AM -0600, Alex Chiang wrote: > > This was #define'd as 0 on all platforms, so let's get rid of it. > > > > This change makes pci_scan_slot() slightly easier to read. > > I don't see why one would want to have a non-zero pcibios_scan_all_fns() > anyway. If you have real hardware, absolutely. If you have a hypervisor that gives you function 5 of a device (instead of mapping your function 0 to function 5 of the real device), you'll want something along these lines. -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step." -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/