Message-ID: <4A3FBA11.8030304@inria.fr>
Date: Mon, 22 Jun 2009 19:06:25 +0200
From: Brice Goglin <Brice.Goglin@inria.fr>
User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103)
MIME-Version: 1.0
To: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
CC: Stefan Lankes <lankes@lfbs.rwth-aachen.de>,
       "'Andi Kleen'" <andi@firstfloor.org>, linux-kernel@vger.kernel.org,
       linux-numa@vger.kernel.org, Boris Bierbaum <boris@lfbs.rwth-aachen.de>,
       KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
       Balbir Singh <balbir@linux.vnet.ibm.com>,
       KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [RFC PATCH 0/4]: affinity-on-next-touch
References: <000c01c9d212$4c244720$e46cd560$@rwth-aachen.de>	 <87zldjn597.fsf@basil.nowhere.org>	 <000001c9eac4$cb8b6690$62a233b0$@rwth-aachen.de>	 <20090612103251.GJ25568@one.firstfloor.org>	 <004001c9eb53$71991300$54cb3900$@rwth-aachen.de>	 <1245119977.6724.40.camel@lts-notebook>	 <003001c9ee8a$97e5b100$c7b11300$@rwth-aachen.de>	 <1245164395.15138.40.camel@lts-notebook>	 <000501c9ef1f$930fa330$b92ee990$@rwth-aachen.de>	 <1245299856.6431.30.camel@lts-notebook>  <4A3F7A49.6070805@inria.fr>	 <1245680649.7799.54.camel@lts-notebook>  <4A3FA326.8030802@inria.fr> <1245689724.7799.124.camel@lts-notebook>
In-Reply-To: <1245689724.7799.124.camel@lts-notebook>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1395
Lines: 36

Lee Schermerhorn wrote:
> The primary difference should be at unmap time, right?  In the fault
> path, I only update the pte of the faulting task.  That's why I require
> the [anon] pages to be in the swap cache [or something similar].  I
> don't want to be fixing up other tasks' page tables in the context of
> the faulting task's fault handler.  If, later, another task touches the
> page, it will take a minor fault and find the [possibly migrated] page
> in the cache.  Hmmm, I guess all tasks WILL incur the minor fault if
> they touch the page after the unmap.  That could be part of the
> difference if you compare on the same kernel version.
>   

Agreed.

> Try booting with cgroup_disable=memory on the command line, if you have
> the memory resource controller configured in.  See what that does to
> your measurements.
>   

It doesn't seem to help. I'll try to bisect and find where the
performance dropped.

> ??? I would expect low level page copying to be highly optimized per
> arch, and also fairly stable.

I just did a quick copy_page benchmark and didn't see any performance
difference between 2.6.27 and mmotm.

thanks,
Brice

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/