Date: Mon, 22 Jun 2009 18:06:50 +0100
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Chuck Ebbert <cebbert@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org
Subject: Re: [patch] Remove tty low_latency flag setting from drivers/char/
Message-ID: <20090622180650.1d5a6515@lxorguk.ukuu.org.uk>
In-Reply-To: <20090622123250.5c2cd13e@dhcp-100-2-144.bos.redhat.com>
References: <20090622123250.5c2cd13e@dhcp-100-2-144.bos.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1356
Lines: 40

> Remove tty low_latency flag setting from drivers/char/.
> 
> The kernel oopses if this flag is set.

ipwireless_network_packet_received is not called from an IRQ path but
from a sleeping one. Please provide a trace of whatever you see failing
with that one as it should be fine and that isn't a bug fix. It may or
may not need low_latency but something else is wrong if it matters.

> 
> Signed-off-by: Chuck Ebbert <cebbert@redhat.com>
> 
> --- linux-2.6.30.noarch.orig/drivers/char/nozomi.c
> +++ linux-2.6.30.noarch/drivers/char/nozomi.c
> @@ -1591,8 +1591,6 @@ static int ntty_open(struct tty_struct *
>  
>  	/* Enable interrupt downlink for channel */
>  	if (port->port.count == 1) {
> -		/* FIXME: is this needed now ? */
> -		tty->low_latency = 1;

This one is correct.

> --- linux-2.6.30.noarch.orig/drivers/char/mxser.c
> +++ linux-2.6.30.noarch/drivers/char/mxser.c
> @@ -1048,8 +1048,6 @@ static int mxser_open(struct tty_struct 
>  	if (retval)
>  		return retval;
>  
> -	/* unmark here for very high baud rate (ex. 921600 bps) used */
> -	tty->low_latency = 1;
>  	return 0;
>  }

As is this
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/