Subject: Re: [PATCH] Add new TAINT_KSPLICE flag for when a Ksplice update
 has been loaded.
From: Jon Masters <jonathan@jonmasters.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Tim Abbott <tabbott@ksplice.com>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       Linux kernel mailing list <linux-kernel@vger.kernel.org>,
       Arjan van de Ven <arjan@infradead.org>,
       Alexey Dobriyan <adobriyan@gmail.com>,
       Andrew Morton <akpm@linux-foundation.org>,
       Anders Kaseorg <andersk@ksplice.com>,
       Jeffrey B Arnold <jbarnold@ksplice.com>
In-Reply-To: <1245660614.19816.203.camel@twins>
References: <alpine.DEB.1.10.0906191422460.29844@vinegar-pot.mit.edu>
	 <1245442307.16209.66.camel@laptop>
	 <1245657114.3265.4074.camel@perihelion.bos.jonmasters.org>
	 <1245660614.19816.203.camel@twins>
Content-Type: text/plain
Organization: World Organi[sz]ation Of Broken Dreams
Date: Mon, 22 Jun 2009 17:25:32 -0400
Message-Id: <1245705932.15044.41.camel@localhost.localdomain>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2978
Lines: 63

On Mon, 2009-06-22 at 10:50 +0200, Peter Zijlstra wrote:
> On Mon, 2009-06-22 at 03:51 -0400, Jon Masters wrote:
> > On Fri, 2009-06-19 at 22:11 +0200, Peter Zijlstra wrote:
> > > On Fri, 2009-06-19 at 15:57 -0400, Tim Abbott wrote:
> > > > Distributions and kerneloops.org have requested that the Ksplice
> > > > rebootless update system taint the kernel the first time that a
> > > > Ksplice update is installed, in order to assist with bug triage.
> > > > 
> > > > Ksplice uses a new taint flag, TAINT_KSPLICE, displayed as 'K', for
> > > > this purpose.
> > > > 
> > > > We would like to confirm that this use of taint meets with the
> > > > community's approval and get this taint flag registered in mainline.
> > > > 
> > > > Signed-off-by: Tim Abbott <tabbott@ksplice.com>
> > > 
> > > Since all of ksplice is still out-of-tree, it seems to me this taint
> > > should be too.
> > 
> > Respectfully, I disagree.
> > 
> > The thing is, distribution maintainers and others would really benefit
> > from knowing if this stuff is loaded today, before the possible eventual
> > addition of ksplice upstream. We already have tainting for non-GPL code
> > and I don't see us arguing about the fact that the kernel has no non-GPL
> > code actually shipping in it to cause such taints to get set :)
> 
> But without ksplice patches you cannot ksplice, right?

Nah. This is a common missunderstanding. Ksplice actually doesn't need
any in-kernel patches, but it does include a rather uncomfortable (from
upstream PoV) disassembler to help it with patching. To avoid this, the
Ksplice guys are looking to get some of the split function sections
stuff, etc. upstream so that they don't need the extraneous stuff.

> That is, there is
> a non trivial patch to the kernel to make this happen afaik.

Well, actually there are several ways that could get in upstream - even
just the base bits are useful. Upstream may never take the shadow data
structure tracking kABI stuff that also comes with Ksplice (I can,
however, think of a few distributions that might be interested in adding
those bits for themselves sometime), but that can live in their module.

> If distros
> ship that, then they can add this taint flag as well. No need to burden
> mainline with any of that until it ksplice proper makes it in.

Nah. We need a flag. It's a really nice way to know "is this backtrace
I'm seeing coming from the kernel that I shipped?". Just imagine you're
one of the folks in $enterprise_vendor who needs to figure this out
(sure you should get there from the linked module list if you've half a
brain, but perhaps "you" is actually an automated tool, like sosreport
on RH systems and I'm sure other vendors have their own equivalents).

Jon.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/