Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757223AbZFWD0d (ORCPT ); Mon, 22 Jun 2009 23:26:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752206AbZFWD00 (ORCPT ); Mon, 22 Jun 2009 23:26:26 -0400 Received: from e28smtp08.in.ibm.com ([59.145.155.8]:33875 "EHLO e28smtp08.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751372AbZFWD0Z (ORCPT ); Mon, 22 Jun 2009 23:26:25 -0400 Message-ID: <4A404B5F.80903@in.ibm.com> Date: Tue, 23 Jun 2009 08:56:23 +0530 From: Sachin Sant User-Agent: Thunderbird 2.0.0.19 (X11/20081216) MIME-Version: 1.0 To: Linus Torvalds CC: Benjamin Herrenschmidt , James Bottomley , Pekka Enberg , linux-kernel , "Rafael J. Wysocki" Subject: Re: [PATCH] mm/init: cpu_hotplug_init() must be initialized before SLAB References: <1245717089.4017.18.camel@pasglop> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 860 Lines: 37 Linus Torvalds wrote: > On Tue, 23 Jun 2009, Benjamin Herrenschmidt wrote: > > >> + /* >> + * This initializes the mutex used by get/put_online_cpus() >> + * which is used by SLAB >> + */ >> + cpu_hotplug_init(); >> > > Oh fudge it. > > Why not get rid of that stupid thing, rather than have that subtle > dependency and a comment for it. > > IOW, does this simpler alternative also work? This fixes the problem for me. Thanks -Sachin -- --------------------------------- Sachin Sant IBM Linux Technology Center India Systems and Technology Labs Bangalore, India --------------------------------- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/