Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752780AbZFWEET (ORCPT ); Tue, 23 Jun 2009 00:04:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750729AbZFWEEG (ORCPT ); Tue, 23 Jun 2009 00:04:06 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:34690 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750716AbZFWEEG (ORCPT ); Tue, 23 Jun 2009 00:04:06 -0400 Subject: Re: [PATCH] mm/init: cpu_hotplug_init() must be initialized before SLAB From: James Bottomley To: Linus Torvalds Cc: Benjamin Herrenschmidt , Pekka Enberg , linux-kernel , "Rafael J. Wysocki" , Sachin Sant In-Reply-To: References: <1245717089.4017.18.camel@pasglop> Content-Type: text/plain Date: Mon, 22 Jun 2009 23:00:53 -0500 Message-Id: <1245729653.17035.43.camel@mulgrave.site> Mime-Version: 1.0 X-Mailer: Evolution 2.24.1.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 709 Lines: 27 On Mon, 2009-06-22 at 19:29 -0700, Linus Torvalds wrote: > > On Tue, 23 Jun 2009, Benjamin Herrenschmidt wrote: > > > + /* > > + * This initializes the mutex used by get/put_online_cpus() > > + * which is used by SLAB > > + */ > > + cpu_hotplug_init(); > > Oh fudge it. > > Why not get rid of that stupid thing, rather than have that subtle > dependency and a comment for it. > > IOW, does this simpler alternative also work? Yes, works for me. James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/