Date: Mon, 22 Jun 2009 22:55:53 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Dave Young <hidave.darkstar@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, linux-kernel@vger.kernel.org,
       Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] printk boot_delay: use loops_per_msec instead of 
 printk_delay_msec
Message-Id: <20090622225553.8aa1dfb7.akpm@linux-foundation.org>
In-Reply-To: <a8e1da0906160202r7124b8a7x29ace04cd910df52@mail.gmail.com>
References: <a8e1da0906160202r7124b8a7x29ace04cd910df52@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1318
Lines: 36

On Tue, 16 Jun 2009 17:02:24 +0800 Dave Young <hidave.darkstar@gmail.com> wrote:

> Sorry, should post this firstly because the previous printk_delay
> patch depends on this,
> please review, thanks.
> --
> 
> Use loops_per_msec instead of printk_delay_msec for boot printk delay.
> 

The changelog is poor, because it fails to describe _why_ this change
is being made.  I rewrote it to

  Rename `printk_delay_msec' to `loops_per_msec', because the patch
  "printk: add printk_delay to make messages readable for some
  scenarios" wishes to more appropriately use the `printk_delay_msec'
  identifier.

> 
> --- linux-2.6.orig/kernel/printk.c	2009-06-15 10:53:10.000000000 +0800
> +++ linux-2.6/kernel/printk.c	2009-06-15 13:17:13.000000000 +0800
> @@ -198,12 +198,11 @@ __setup("log_buf_len=", log_buf_len_setu
>  #ifdef CONFIG_BOOT_PRINTK_DELAY
> 
>  static unsigned int boot_delay; /* msecs delay after each printk
> during bootup */
> -static unsigned long long printk_delay_msec; /* per msec, based on
> boot_delay */

Your email client is wordwrapping the patches.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/