Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757138AbZFWF7k (ORCPT ); Tue, 23 Jun 2009 01:59:40 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751495AbZFWF7d (ORCPT ); Tue, 23 Jun 2009 01:59:33 -0400 Received: from courier.cs.helsinki.fi ([128.214.9.1]:45282 "EHLO mail.cs.helsinki.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751076AbZFWF7c (ORCPT ); Tue, 23 Jun 2009 01:59:32 -0400 Subject: Re: [PATCH] mm/init: cpu_hotplug_init() must be initialized before SLAB From: Pekka Enberg To: Linus Torvalds Cc: Benjamin Herrenschmidt , James Bottomley , linux-kernel , "Rafael J. Wysocki" , Sachin Sant In-Reply-To: References: <1245717089.4017.18.camel@pasglop> Date: Tue, 23 Jun 2009 08:59:33 +0300 Message-Id: <1245736773.2880.0.camel@penberg-laptop> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 7bit X-Mailer: Evolution 2.24.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 915 Lines: 29 On Tue, 23 Jun 2009, Benjamin Herrenschmidt wrote: > > + /* > > + * This initializes the mutex used by get/put_online_cpus() > > + * which is used by SLAB > > + */ > > + cpu_hotplug_init(); On Mon, 2009-06-22 at 19:29 -0700, Linus Torvalds wrote: > Oh fudge it. > > Why not get rid of that stupid thing, rather than have that subtle > dependency and a comment for it. > > IOW, does this simpler alternative also work? > > When given the choice of simplifying and removing code, always do so. > > Static initializers are much nicer than having to worry about when > something gets initialized, no? Looks good to me. Thanks for fixing it up, Linus! Pekka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/