Date: Tue, 23 Jun 2009 09:19:44 +0200
From: Ingo Molnar <mingo@elte.hu>
To: akpm@linux-foundation.org
Cc: mm-commits@vger.kernel.org, hidave.darkstar@gmail.com,
       linux-kernel@vger.kernel.org
Subject: Re: +
	printk-add-printk_delay-to-make-messages-readable-for-some-scenarios
	.patch added to -mm tree
Message-ID: <20090623071944.GB5747@elte.hu>
References: <200906230552.n5N5q3al012876@imap1.linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200906230552.n5N5q3al012876@imap1.linux-foundation.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 648
Lines: 27


two minor comments:

> +++ a/kernel/printk.c
> @@ -640,6 +640,19 @@ static int recursion_bug;
>  static int new_text_line = 1;
>  static char printk_buf[1024];
>  
> +int printk_delay_msec;

should be __read_mostly.

> +
> +static inline void printk_delay(void)
> +{
> +	if (unlikely(printk_delay_msec)) {
> +		int m = printk_delay_msec;
> +		while (m--) {

newline needed after local variable.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/