Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759204AbZFWI5P (ORCPT ); Tue, 23 Jun 2009 04:57:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758492AbZFWI47 (ORCPT ); Tue, 23 Jun 2009 04:56:59 -0400 Received: from mx2.redhat.com ([66.187.237.31]:42926 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752965AbZFWI46 (ORCPT ); Tue, 23 Jun 2009 04:56:58 -0400 Date: Tue, 23 Jun 2009 11:56:33 +0300 From: "Michael S. Tsirkin" To: Gregory Haskins Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, avi@redhat.com, mtosatti@redhat.com, paulmck@linux.vnet.ibm.com, markmc@redhat.com Subject: Re: [KVM PATCH v8 3/3] KVM: add iosignalfd support Message-ID: <20090623085633.GA16294@redhat.com> References: <20090619002224.15859.97977.stgit@dev.haskins.net> <20090619003045.15859.73197.stgit@dev.haskins.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090619003045.15859.73197.stgit@dev.haskins.net> User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 832 Lines: 20 On Thu, Jun 18, 2009 at 08:30:46PM -0400, Gregory Haskins wrote: > +static int > +iosignalfd_group_in_range(struct kvm_io_device *this, gpa_t addr, int len, > + int is_write) > +{ > + struct _iosignalfd_group *p = to_group(this); > + > + return ((addr >= p->addr && (addr < p->addr + p->length))); > +} I think I see a problem here. For virtio, we do not necessarily want all virtqueues for a device to live in kernel: there might be control virtqueues that we want to leave in userspace. Since this claims all writes to a specific address, the signal never makes it to userspace. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/