From: Arnd Bergmann <arnd@arndb.de>
To: liqin.chen@sunplusct.com
Subject: Re: S+core architecture (arch/score/) support files
Date: Tue, 23 Jun 2009 11:43:22 +0200
User-Agent: KMail/1.11.90 (Linux/2.6.30-9-generic; KDE/4.2.90; x86_64; ; )
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
       linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
References: <OF318304AE.9C3DA8BC-ON482575DE.002B7553-482575DE.002FC96B@sunplusct.com>
In-Reply-To: <OF318304AE.9C3DA8BC-ON482575DE.002B7553-482575DE.002FC96B@sunplusct.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <200906231143.22985.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1848
Lines: 41

On Tuesday 23 June 2009, liqin.chen@sunplusct.com wrote:
> Hi Linus,
> 
> This repository contains Linux support for S+core CPU.
> 
> Please pull
> git://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git score

I've helped Liquin getting this into a state for inclusion,
so I'll share my observations about the submission.

The code looks very clean for a new architecture support, with the
exception of a few misformatted comments and similar minor issues.
By using the asm-generic headers that are now in 2.6.31, the amount
of copy-paste programming was reduced to a minimum, the total amount
of code added is much less than any other architecture (200kb score,
290kb h8300, 570kb microblaze are the smallest ones).
Fixes for any issues noted during review usually came in quickly.

S+core is now the first architecture to use the ABI defined in
asm-generic, which means it can serve as an example for other
architectures that want to merge their code in the future.

Unfortunately, I don't think that the score glibc has been fully
ported to support this, so it also means that the version that is
being submitted has undergone any run-time testing. I did check
that it compiles fine but could not do more in lack of hardware
or even just a user space distro.

Another small negative is that Liquin is still unexperienced with
the procedures we use in Linux. I've helped out by providing
my git tree, but am not planning to do that beyond 2.6.31.
Given that he has also been upstream gcc maintainer for S+core
for well over 2 years, I believe merging it now will work out well.

	Arnd <><
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/