Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758960AbZFWNAo (ORCPT ); Tue, 23 Jun 2009 09:00:44 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752299AbZFWNAh (ORCPT ); Tue, 23 Jun 2009 09:00:37 -0400 Received: from dan.rpsys.net ([93.97.175.187]:55613 "EHLO dan.rpsys.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752105AbZFWNAg (ORCPT ); Tue, 23 Jun 2009 09:00:36 -0400 Subject: Re: Bug in tdo24m From: Richard Purdie To: Aviv Laufer Cc: eric.miao@marvell.com, linux-kernel@vger.kernel.org In-Reply-To: <87972c700906230516n538ad959nbd4b1ea21943ffc2@mail.gmail.com> References: <87972c700906230516n538ad959nbd4b1ea21943ffc2@mail.gmail.com> Content-Type: text/plain Date: Tue, 23 Jun 2009 13:58:53 +0100 Message-Id: <1245761933.5987.20.camel@dax.rpnet.com> Mime-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 732 Lines: 25 Hi, On Tue, 2009-06-23 at 15:16 +0300, Aviv Laufer wrote: > I have found a bug in tdo24m.c . > There is a call to kmalloc with the second param is sizeeof (flag) > instead of flag. > This cause a crash. Thats quite a nasty bug and its surprising its not been found before now! Can you resubmit the patch with description and most importantly a Signed-off-by line please (see Documentation/SubmittingPatches)? Cheers, Richard -- Richard Purdie Intel Open Source Technology Centre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/