Message-ID: <4A40D6FD.8000903@novell.com>
Date: Tue, 23 Jun 2009 09:22:05 -0400
From: Gregory Haskins <ghaskins@novell.com>
User-Agent: Thunderbird 2.0.0.21 (Macintosh/20090302)
MIME-Version: 1.0
To: "Michael S. Tsirkin" <mst@redhat.com>
CC: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, avi@redhat.com,
       mtosatti@redhat.com, paulmck@linux.vnet.ibm.com, markmc@redhat.com
Subject: Re: [KVM PATCH v8 3/3] KVM: add iosignalfd support
References: <20090619002224.15859.97977.stgit@dev.haskins.net> <20090619003045.15859.73197.stgit@dev.haskins.net> <20090623085633.GA16294@redhat.com>
In-Reply-To: <20090623085633.GA16294@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enig8A6A6F26E99CB4D22D02974E"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1893
Lines: 55

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig8A6A6F26E99CB4D22D02974E
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Michael S. Tsirkin wrote:
> On Thu, Jun 18, 2009 at 08:30:46PM -0400, Gregory Haskins wrote:
>  =20
>> +static int
>> +iosignalfd_group_in_range(struct kvm_io_device *this, gpa_t addr, int=
 len,
>> +			  int is_write)
>> +{
>> +	struct _iosignalfd_group *p =3D to_group(this);
>> +
>> +	return ((addr >=3D p->addr && (addr < p->addr + p->length)));
>> +}
>>    =20
>
> I think I see a problem here. For virtio, we do not necessarily want al=
l
> virtqueues for a device to live in kernel: there might be control
> virtqueues that we want to leave in userspace. Since this claims all
> writes to a specific address, the signal never makes it to userspace.
>
>  =20
So based on this, I think you are right about the io_bus changes.  If we
accept your proposal this problem above is solved cleanly.  Sorry for
the resistance, but I just wanted to make sure we were doing the right
thing.  I am in agreement now.

Kind Regards,
-Greg


--------------enig8A6A6F26E99CB4D22D02974E
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.0.11 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkpA1v0ACgkQlOSOBdgZUxnfPwCeOm4u715yffqav313qj7XBjt+
bTwAn26PbJBJYKhi0EZVay380A3eQv34
=XjjJ
-----END PGP SIGNATURE-----

--------------enig8A6A6F26E99CB4D22D02974E--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/