Date: Tue, 23 Jun 2009 10:02:06 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Paul Fulghum <paulkf@microgate.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
       "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] synclink_gt fix transmit race and timeout
Message-Id: <20090623100206.fac4dde7.akpm@linux-foundation.org>
In-Reply-To: <4A4116FA.1060603@microgate.com>
References: <1245181451.3727.5.camel@x2.microgate.com>
	<20090622231937.2d32898e.akpm@linux-foundation.org>
	<1245770161.3701.42.camel@x2.microgate.com>
	<20090623092739.5a8e9dd5.akpm@linux-foundation.org>
	<4A4116FA.1060603@microgate.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 745
Lines: 24

On Tue, 23 Jun 2009 11:55:06 -0600 Paul Fulghum <paulkf@microgate.com> wrote:

> Andrew Morton wrote:
> > I did have a couple of other comments on the patch which seem to have
> > been missed?
> 
> Let's see, there was:
> "It fails to explain the user-visible effects of the bug which was fixed."

I'm referring to

  Where did the "7" come from?

and

  I have a suspicion that tx_stop() should use del_timer_sync(), not
  del_timer().  What happens if the timer handler is concurrently
  running?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/