Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753533AbZFWRVQ (ORCPT ); Tue, 23 Jun 2009 13:21:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751647AbZFWRVC (ORCPT ); Tue, 23 Jun 2009 13:21:02 -0400 Received: from vms173017pub.verizon.net ([206.46.173.17]:42448 "EHLO vms173017pub.verizon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751428AbZFWRVB (ORCPT ); Tue, 23 Jun 2009 13:21:01 -0400 Date: Tue, 23 Jun 2009 13:20:43 -0400 (EDT) From: Len Brown X-X-Sender: lenb@localhost.localdomain To: Ingo Molnar Cc: "H. Peter Anvin" , Thomas Gleixner , Yinghai Lu , Andrew Morton , Linus Torvalds , sfi-devel@simplefirmware.org, Linux Kernel Mailing List , Feng Tang , Andi Kleen Subject: Re: [PATCH 3/8] SFI: core support In-reply-to: <20090623075643.GC6397@elte.hu> Message-id: References: <7425334c8329b15bec7cb4ecd0b17af042e97465.1245740912.git.len.brown@intel.com> <8d9bab79ce1169afd419035f70177e52d47626ca.1245740912.git.len.brown@intel.com> <20090623075643.GC6397@elte.hu> User-Agent: Alpine 2.00 (LFD 1167 2008-08-23) MIME-version: 1.0 Content-type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 610 Lines: 18 Re: #define PREFIX "SFI: " The SFI code uses all pr_info/debug/warning/err format and so it looks like the way to go is like this; #define KMSG_COMPONENT "SFI" #define pr_fmt(fmt) KMSG_COMPONENT ": " fmt and get rid of the PREFIX stuff in the actual messages. Is that the recommended way to go these days? thanks, -Len Brown, Intel Open Soruce Technolgy Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/