Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755540AbZFWSba (ORCPT ); Tue, 23 Jun 2009 14:31:30 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755379AbZFWSbM (ORCPT ); Tue, 23 Jun 2009 14:31:12 -0400 Received: from mx2.redhat.com ([66.187.237.31]:39315 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755370AbZFWSbK (ORCPT ); Tue, 23 Jun 2009 14:31:10 -0400 Message-ID: <4A411F14.1080406@redhat.com> Date: Tue, 23 Jun 2009 21:29:40 +0300 From: Avi Kivity User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1b3pre) Gecko/20090513 Fedora/3.0-2.3.beta2.fc11 Thunderbird/3.0b2 MIME-Version: 1.0 To: Matthew Wilcox CC: Alex Chiang , jbarnes@virtuousgeek.org, linux-arch@vger.kernel.org, Kyle McMartin , Tony Luck , Russell King , Arnd Bergmann , Yoshinori Sato , Benjamin Herrenschmidt , Jeff Dike , linux-kernel@vger.kernel.org, Ralf Baechle , David Howells , Paul Mundt , Ivan Kokshaysky , Ingo Molnar , "David S. Miller" Subject: Re: [PATCH] PCI: remove pcibios_scan_all_fns() References: <20090622140807.25509.54448.stgit@bob.kio> <20090622143431.GT19977@parisc-linux.org> In-Reply-To: <20090622143431.GT19977@parisc-linux.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1400 Lines: 42 On 06/22/2009 05:34 PM, Matthew Wilcox wrote: > >> diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c >> index f1ae247..b613cad 100644 >> --- a/drivers/pci/probe.c >> +++ b/drivers/pci/probe.c >> @@ -1056,8 +1056,7 @@ int pci_scan_slot(struct pci_bus *bus, int devfn) >> if (dev&& !dev->is_added) /* new device? */ >> nr++; >> >> - if ((dev&& dev->multifunction) || >> - (!dev&& pcibios_scan_all_fns(bus, devfn))) { >> + if (dev&& dev->multifunction) { >> for (fn = 1; fn< 8; fn++) { >> dev = pci_scan_single_device(bus, devfn + fn); >> if (dev) { >> > > What a good idea. I was just looking at making this more complicated > (due to the ARI capability). > > I'd like to know what the KVM / Xen / ... people think about this. > I don't know if they rely on function 5 being able to show up out of > the blue. > > You mean have a function 5 without a function 0? This doesn't impact kvm at all. Moreover, I see pcibios_scan_all_fns() uniformly defined as 0, so this patch doesn't change much, does it? -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/