Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754927AbZFWTVF (ORCPT ); Tue, 23 Jun 2009 15:21:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755389AbZFWTUu (ORCPT ); Tue, 23 Jun 2009 15:20:50 -0400 Received: from pfepb.post.tele.dk ([195.41.46.236]:44856 "EHLO pfepb.post.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755714AbZFWTUt (ORCPT ); Tue, 23 Jun 2009 15:20:49 -0400 Date: Tue, 23 Jun 2009 21:23:04 +0200 From: Sam Ravnborg To: Kyle McMartin Cc: Stephen Rothwell , Linus , James Simmons , LKML , Krzysztof Helt , Geert Uytterhoeven , Andrew Morton , ppc-dev Subject: Re: [PATCH v2] fbdev: work around old compiler bug Message-ID: <20090623192304.GA23124@uranus.ravnborg.org> References: <20090622180420.2e0424e4.sfr@canb.auug.org.au> <20090622183415.46fa786b.sfr@canb.auug.org.au> <20090623154428.e2f4ddc9.sfr@canb.auug.org.au> <20090623164505.GA3101@bombadil.infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090623164505.GA3101@bombadil.infradead.org> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1335 Lines: 32 On Tue, Jun 23, 2009 at 12:45:05PM -0400, Kyle McMartin wrote: > On Tue, Jun 23, 2009 at 03:44:28PM +1000, Stephen Rothwell wrote: > > When building with a 4.1.x compiler on powerpc64 (at least) we get > > this error: > > > > drivers/video/logo/logo_linux_mono.c:81: error: logo_linux_mono causes a section type conflict > > > > This was introduced by commit ae52bb2384f721562f15f719de1acb8e934733cb > > ("fbdev: move logo externs to header file"). This is a partial revert > > of that commit sufficient to not hit the compiler bug. > > > > We're seeing similar issues with 4.3 on parisc (the case I saw today was > in fs/nfs/nfsroot.c...) Any ideas on the actual culprit or is it just > gcc being unfriendly? Al analysed this some time ago. When we say something is const then _sometimes_ gcc annotate the section as const(*) - sometimes not. So if we have two variables/functions annotated __*const and gcc decides to annotate the section const only in one case we get a section type conflict. (*) it is named something else I do not recall at the moment in linker language. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/