Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755311AbZFWT0Y (ORCPT ); Tue, 23 Jun 2009 15:26:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753990AbZFWT0O (ORCPT ); Tue, 23 Jun 2009 15:26:14 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:47443 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753878AbZFWT0N (ORCPT ); Tue, 23 Jun 2009 15:26:13 -0400 X-Auth-Info: GWx2JHzxBtgJ+OJImfX7G/1ZssN4tVXCdtHqoAN7+ho= Message-ID: <4A412C53.8050607@grandegger.com> Date: Tue, 23 Jun 2009 21:26:11 +0200 From: Wolfgang Grandegger User-Agent: Thunderbird 2.0.0.21 (X11/20090320) MIME-Version: 1.0 To: Heiko Carstens CC: David Miller , Oliver Hartkopp , Martin Schwidefsky , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] can: let SJA1000 driver depend on HAS_IOMEM References: <20090623073120.GA5955@osiris.boeblingen.de.ibm.com> In-Reply-To: <20090623073120.GA5955@osiris.boeblingen.de.ibm.com> X-Enigmail-Version: 0.95.7 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2466 Lines: 64 Heiko Carstens wrote: > From: Heiko Carstens > > Fixes this compile error on s390: > > drivers/net/can/sja1000/sja1000_platform.c: In function 'sp_read_reg': > drivers/net/can/sja1000/sja1000_platform.c:42: error: implicit declaration of function 'ioread8' > drivers/net/can/sja1000/sja1000_platform.c: In function 'sp_write_reg': > drivers/net/can/sja1000/sja1000_platform.c:47: error: implicit declaration of function 'iowrite8' > drivers/net/can/sja1000/sja1000_platform.c: In function 'sp_probe': > drivers/net/can/sja1000/sja1000_platform.c:79: error: implicit declaration of function 'ioremap_nocache' > > Cc: Wolfgang Grandegger > Cc: Oliver Hartkopp > Signed-off-by: Heiko Carstens > --- > drivers/net/can/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > Index: linux-2.6/drivers/net/can/Kconfig > =================================================================== > --- linux-2.6.orig/drivers/net/can/Kconfig > +++ linux-2.6/drivers/net/can/Kconfig > @@ -36,7 +36,7 @@ config CAN_CALC_BITTIMING > If unsure, say Y. > > config CAN_SJA1000 > - depends on CAN_DEV > + depends on CAN_DEV && HAS_IOMEM > tristate "Philips SJA1000" > ---help--- > Driver for the SJA1000 CAN controllers from Philips or NXP Hm, this Kconfig entry is not directly responsible for building sja1000_platform.o. It builds sja1000.o, which does not rely on HAS_IOMEM. It should be added to "config CAN_SJA1000_PLATFORM" instead. Does the patch below work for you? Wolfgang. --- drivers/net/can/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: net-next-2.6/drivers/net/can/Kconfig =================================================================== --- net-next-2.6.orig/drivers/net/can/Kconfig +++ net-next-2.6/drivers/net/can/Kconfig @@ -42,7 +42,7 @@ config CAN_SJA1000 Driver for the SJA1000 CAN controllers from Philips or NXP config CAN_SJA1000_PLATFORM - depends on CAN_SJA1000 + depends on HAS_IOMEM && CAN_SJA1000 tristate "Generic Platform Bus based SJA1000 driver" ---help--- This driver adds support for the SJA1000 chips connected to -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/