Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757175AbZFWVGF (ORCPT ); Tue, 23 Jun 2009 17:06:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755102AbZFWVFN (ORCPT ); Tue, 23 Jun 2009 17:05:13 -0400 Received: from x35.xmailserver.org ([64.71.152.41]:54178 "EHLO x35.xmailserver.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755526AbZFWVFL (ORCPT ); Tue, 23 Jun 2009 17:05:11 -0400 X-AuthUser: davidel@xmailserver.org Date: Tue, 23 Jun 2009 13:59:07 -0700 (PDT) From: Davide Libenzi X-X-Sender: davide@makko.or.mcafeemobile.com To: Andrew Morton cc: Linux Kernel Mailing List , avi@redhat.com, kvm@vger.kernel.org, ghaskins@novell.com, Rusty Russell , Benjamin LaHaise Subject: Re: [patch] eventfd - revised interface and cleanups (2nd rev) In-Reply-To: <20090623131239.711d9f83.akpm@linux-foundation.org> Message-ID: References: <20090623131239.711d9f83.akpm@linux-foundation.org> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) X-GPG-FINGRPRINT: CFAE 5BEE FD36 F65E E640 56FE 0974 BF23 270F 474E X-GPG-PUBLIC_KEY: http://www.xmailserver.org/davidel.asc MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1414 Lines: 36 On Tue, 23 Jun 2009, Andrew Morton wrote: > On Tue, 23 Jun 2009 12:25:36 -0700 (PDT) > Davide Libenzi wrote: > > > Another cleanup this patch does, is making AIO select EVENTFD, instead of > > adding a bunch of empty function stubs inside eventfd.h in order to > > handle the (AIO && !EVENTFD) case. > > Given that we're trying to squeak this patch into 2.6.31, it's quite > unfortunate to include unrelated changes. Especially ones which > involve the always-problematic "select". Although this one looks less > than usually deadly due to the simple dependencies of AIO and eventfd. > > However... > > Is this a good way of fixing the (AIO && !EVENTFD) case? Surely if the > developer selected this combination, he doesn't want to carry the > overhead of including eventfd. IOW, if AIO can work acceptably without > eventfd being compiled into the kernel then adding the stubs is a > superior solution. IMO when someone says "AIO included in the kernel", should get the whole AIO functionality and not part of it. People already started using KAIO+eventfd, and a (AIO && !EVENTFD) config will make their code fail. - Davide -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/