Date: Tue, 23 Jun 2009 19:04:26 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Mike Frysinger <vapier.adi@gmail.com>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, rgetz@blackfin.uclinux.org
Subject: Re: [PATCH 1/4] asm/sections: add text/data checking functions for
  arches to override
Message-Id: <20090623190426.d4cc9853.akpm@linux-foundation.org>
In-Reply-To: <8bd0f97a0906231848u61d07a3j803f51cb26b72dab@mail.gmail.com>
References: <1245255744-21039-1-git-send-email-vapier@gentoo.org>
	<20090623154022.61e83c33.akpm@linux-foundation.org>
	<8bd0f97a0906231848u61d07a3j803f51cb26b72dab@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1138
Lines: 36

On Tue, 23 Jun 2009 21:48:03 -0400 Mike Frysinger <vapier.adi@gmail.com> wrote:

> > I suppose that for completeness and consistency etc really we should have
> >
> > #define arch_is_kernel_text arch_is_kernel_text
> > #define arch_is_kernel_data arch_is_kernel_data
> >
> > in here.
> 
> *shrug* other places that use this style dont include these defines
> for completeness

Examples?

All the ones I can find do things like

#ifndef vmcore_elf_check_arch_cross
#define vmcore_elf_check_arch_cross(x) 0
#endif

> as the define muck is for the header to know about
> (arches providing their own version), not any source code -- they
> shouldnt know anything about the ifdef stuff.

Failing to do the #define will have various tricky failure modes.  But
it's more a question of "what is the _right_ thing to do", then doing
that consistently.

>  i dont care much either way.

Someone has to.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/