Date: Tue, 23 Jun 2009 19:51:59 -0700 (PDT)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: "Serge E. Hallyn" <serue@us.ibm.com>
cc: Trond Myklebust <Trond.Myklebust@netapp.com>,
       Al Viro <viro@ZenIV.linux.org.uk>,
       Christoph Hellwig <hch@infradead.org>, linux-fsdevel@vger.kernel.org,
       linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] VFS: Add VFS helper functions for setting up private
 namespaces
In-Reply-To: <20090623223230.GA30173@us.ibm.com>
Message-ID: <alpine.LFD.2.01.0906231950030.3240@localhost.localdomain>
References: <20090622190913.27923.31665.stgit@heimdal.trondhjem.org> <20090622190913.27923.61549.stgit@heimdal.trondhjem.org> <20090623201307.GA25760@us.ibm.com> <1245792589.5133.24.camel@heimdal.trondhjem.org> <20090623223230.GA30173@us.ibm.com>
User-Agent: Alpine 2.01 (LFD 1184 2008-12-16)
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 720
Lines: 19


On Tue, 23 Jun 2009, Serge E. Hallyn wrote:
>
> (it keeps bugging me that the order of args to list_add() gets reversed
> as a result, but clearly with both starting out empty it doesn't
> matter..)

.. and the new one is more logical. "list_add()" really adds the first 
entry to the list pointed to by the second one. It _works_ the other way 
too in this case, as you point out, but now that you mention it, it really 
looks like the pre-patch code is "wrong".

		Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/