Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756578AbZFXGwz (ORCPT ); Wed, 24 Jun 2009 02:52:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752973AbZFXGwm (ORCPT ); Wed, 24 Jun 2009 02:52:42 -0400 Received: from mo-p00-ob.rzone.de ([81.169.146.161]:32277 "EHLO mo-p00-ob.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752689AbZFXGwl (ORCPT ); Wed, 24 Jun 2009 02:52:41 -0400 X-RZG-AUTH: :P2MHfkW8eP4Mre39l357AZT/I7AY/7nT2yrT1q0ngWNsKR9Dbc7mseH1AU4LKDnsoMWy X-RZG-CLASS-ID: mo00 Message-ID: <4A41CD36.8030202@hartkopp.net> Date: Wed, 24 Jun 2009 08:52:38 +0200 From: Oliver Hartkopp User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103) MIME-Version: 1.0 To: Wolfgang Grandegger CC: Heiko Carstens , David Miller , Martin Schwidefsky , linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] can: let SJA1000 driver depend on HAS_IOMEM References: <20090623073120.GA5955@osiris.boeblingen.de.ibm.com> <4A412C53.8050607@grandegger.com> In-Reply-To: <4A412C53.8050607@grandegger.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1258 Lines: 37 Wolfgang Grandegger wrote: > Heiko Carstens wrote: >> Index: linux-2.6/drivers/net/can/Kconfig >> =================================================================== >> --- linux-2.6.orig/drivers/net/can/Kconfig >> +++ linux-2.6/drivers/net/can/Kconfig >> @@ -36,7 +36,7 @@ config CAN_CALC_BITTIMING >> If unsure, say Y. >> >> config CAN_SJA1000 >> - depends on CAN_DEV >> + depends on CAN_DEV && HAS_IOMEM >> tristate "Philips SJA1000" >> ---help--- >> Driver for the SJA1000 CAN controllers from Philips or NXP > > Hm, this Kconfig entry is not directly responsible for building > sja1000_platform.o. It builds sja1000.o, which does not rely on > HAS_IOMEM. It should be added to "config CAN_SJA1000_PLATFORM" instead. Hi Wolfgang, the question is, if we should add HAS_IOMEM to almost every SJA1000 depended driver like SJA1000_PLATFORM, SJA1000_OF_PLATFORM, EMS_PCI and KVASER_PCI ??? Is it possible to have a support for the SJA1000 that does *not* depend on HAS_IOMEM? Regards, Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/