Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753074AbZFXHfD (ORCPT ); Wed, 24 Jun 2009 03:35:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751996AbZFXHez (ORCPT ); Wed, 24 Jun 2009 03:34:55 -0400 Received: from cantor.suse.de ([195.135.220.2]:40946 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751485AbZFXHez (ORCPT ); Wed, 24 Jun 2009 03:34:55 -0400 From: "NeilBrown" To: "Neil Brown" , "device-mapper development" , "Ken Milmore" , linux-raid@vger.kernel.org, linux-kernel@vger.kernel.org, "Jens Axboe" , "Mikulas Patocka" Date: Wed, 24 Jun 2009 17:34:50 +1000 (EST) Message-ID: In-Reply-To: <20090624070917.GB27500@agk-dp.fab.redhat.com> References: <4A188CAD.1080009@googlemail.com> <0fa4b1e19d3edb12931e0d641ce2c7d7.squirrel@neil.brown.name> <4A3E3C49.7010907@googlemail.com> <19009.41191.662901.179565@notabene.brown> <20090624070917.GB27500@agk-dp.fab.redhat.com> Subject: Re: [dm-devel] Re: Write barriers on MD RAID1 User-Agent: SquirrelMail/1.4.15 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 891 Lines: 26 On Wed, June 24, 2009 5:09 pm, Alasdair G Kergon wrote: > On Wed, Jun 24, 2009 at 01:43:35PM +1000, Neil Brown wrote: >> Since this test was added, barriers have not worked on md, and (I >> think) dm and similar devices that don't use __make_request and so >> don't bother to set next_ordered. > > In dm, we added this: > > + blk_queue_ordered(md->queue, QUEUE_ORDERED_DRAIN, NULL); > I obviously didn't grep for the right thing. This will obviously work, but I can't help thinking it is in the wrong place. I don't even have a queue in md/raid1, so making a statement about how it is ordered just doesn't make sense. Jens? NeilBrown -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/