Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754271AbZFXJHV (ORCPT ); Wed, 24 Jun 2009 05:07:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752320AbZFXJHH (ORCPT ); Wed, 24 Jun 2009 05:07:07 -0400 Received: from mo-p00-ob.rzone.de ([81.169.146.162]:49123 "EHLO mo-p00-ob.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751437AbZFXJHF (ORCPT ); Wed, 24 Jun 2009 05:07:05 -0400 X-RZG-AUTH: :P2MHfkW8eP4Mre39l357AZT/I7AY/7nT2yrT1q0ngWNsKR9Dbc7mseH1AU4KMzD7MA== X-RZG-CLASS-ID: mo00 Message-ID: <4A41ECB8.3060209@hartkopp.net> Date: Wed, 24 Jun 2009 11:07:04 +0200 From: Oliver Hartkopp User-Agent: Mozilla-Thunderbird 2.0.0.19 (X11/20090103) MIME-Version: 1.0 To: Wolfgang Grandegger CC: David Miller , heiko.carstens@de.ibm.com, schwidefsky@de.ibm.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] can: let SJA1000 driver depend on HAS_IOMEM References: <20090623073120.GA5955@osiris.boeblingen.de.ibm.com> <4A412C53.8050607@grandegger.com> <4A41CD36.8030202@hartkopp.net> <20090624.000109.49664041.davem@davemloft.net> <4A41E31B.1030703@grandegger.com> <4A41E56F.6030302@hartkopp.net> <4A41E91F.1020509@grandegger.com> In-Reply-To: <4A41E91F.1020509@grandegger.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1122 Lines: 28 Wolfgang Grandegger wrote: > Oliver Hartkopp wrote: >> Wolfgang Grandegger wrote: >>> We may even consider making CONFIG_CAN >>> depend on HAS_IOMEM like for SPI, USB, Serial, etc. >> Why CONFIG_CAN ?? >> >> CONFIG_CAN provides a network protocol family that can be used e.g. with the >> vcan driver without any hardware. So HAS_IOMEM only has to take care of some >> drivers, that fiddle on CAN controller registers themselves. E.g. for SPI, USB >> and Serial these 'underlying' interfaces bring their own requirements. When we >> depend on SPI, it should bring HAS_IOMEM as a dependency of SPI. > > OK, then s/CONFIG_CAN/CONFIG_CAN_DEV/ IMHO not even CONFIG_CAN_DEV that also provides bittime calculation and standard CAN driver stuff that does not depend on a specific hardware. HAS_IOMEM should be a dependency on specific drivers (like stated above). Regards, Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/