Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752335AbZFXKbS (ORCPT ); Wed, 24 Jun 2009 06:31:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750957AbZFXKbI (ORCPT ); Wed, 24 Jun 2009 06:31:08 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:42677 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750818AbZFXKbH (ORCPT ); Wed, 24 Jun 2009 06:31:07 -0400 X-IronPort-AV: E=Sophos;i="4.42,282,1243828800"; d="scan'208";a="56123303" Subject: Re: [PATCH] PCI: remove pcibios_scan_all_fns() From: Ian Campbell To: Jeremy Fitzhardinge CC: Matthew Wilcox , Benjamin Herrenschmidt , Alex Chiang , , , Kyle McMartin , Tony Luck , Russell King , Arnd Bergmann , Yoshinori Sato , Jeff Dike , , Ralf Baechle , David Howells , Paul Mundt , Ivan Kokshaysky , Ingo Molnar , "David S. Miller" , Avi Kivity In-Reply-To: <4A413C66.5010306@goop.org> References: <20090622140807.25509.54448.stgit@bob.kio> <20090622143431.GT19977@parisc-linux.org> <4A3FCB68.3030004@goop.org> <20090622183056.GY19977@parisc-linux.org> <1245714008.4017.7.camel@pasglop> <20090623190826.GJ19977@parisc-linux.org> <4A413C66.5010306@goop.org> Content-Type: text/plain Organization: Citrix Systems, Inc. Date: Wed, 24 Jun 2009 11:30:54 +0100 Message-ID: <1245839454.31273.40.camel@zakaz.uk.xensource.com> MIME-Version: 1.0 X-Mailer: Evolution 2.22.3.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1465 Lines: 34 On Tue, 2009-06-23 at 13:34 -0700, Jeremy Fitzhardinge wrote: > On 06/23/09 12:08, Matthew Wilcox wrote: > > I think simply materialising them, either the way the OF code does, > > or the way the IOV code does is the best route forwards. > > > > On reflection, I think this will work. We have a Xen pci passthrough > driver which gets told about the passed-through devices via xenbus, and > does the appropriate setup. At first glance, there doesn't seem to be > any problem with that code just explicitly instantiate the devices at > the PCI level in the same way pci_scan_device does (ie, > alloc_pci_device, initalize the dev struct, pci_setup_device). > > Is that what you mean? > > IanC has looked at that code more closely, so perhaps he can confirm > that this will work on our side. I'm not 100% familiar with this stuff but pcifront_rescan_root() currently iterates over all devfns for a bus and calls pci_scan_single_device(). I don't see where we call pci_scan_slot() which I think would be the only way pcibios_scan_all_fns() would matter to us so I'm not sure why we have that patch. It's possible all this has changed since AlexN originally did the work? It was quite a long time ago now. Ian. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/