Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754169AbZFXMWc (ORCPT ); Wed, 24 Jun 2009 08:22:32 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750957AbZFXMWY (ORCPT ); Wed, 24 Jun 2009 08:22:24 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:40723 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750720AbZFXMWY (ORCPT ); Wed, 24 Jun 2009 08:22:24 -0400 Date: Wed, 24 Jun 2009 14:22:09 +0200 From: Ingo Molnar To: Jaswinder Singh Rajput , Jesse Barnes , Len Brown Cc: Larry Finger , Gary Hade , Jesse Barnes , LKML , x86 maintainers , Len Brown , Linus Torvalds Subject: Re: Regression with commit f9cde5f in 2.6.30-gitX Message-ID: <20090624122209.GC20564@elte.hu> References: <4A418254.9050607@lwfinger.net> <1245845787.3093.3.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1245845787.3093.3.camel@localhost.localdomain> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1668 Lines: 45 * Jaswinder Singh Rajput wrote: > On Tue, 2009-06-23 at 20:33 -0500, Larry Finger wrote: > > My latest pull from Linus's tree fails to boot. Bisection leads to the > > commit entitled "x86/ACPI: Correct maximum allowed _CRS returned > > resources and warn if exceeded" with hash > > f9cde5ffed17bf74f6bef042d99edb0622f58576. I have been unable to > > capture the first error message as it scrolls off the screen, but the > > second hits the WARN_ON at drivers/ata/ahci.c:695 in routine > > ahci_enable_ahci() because HOST_AHCI_EN is not set. > > > > This patch fixes boot failure on my AMD 64 laptop, can you please test > this patch: > > [PATCH] x86: fix _CRS resources return handling > > We need to check for info->res_num and only handle for < PCI_BUS_NUM_RESOURCES > > Also set info->bus->resource[info->res_num] for _CRS resources return handling > > Fixed boot failure on some machine. > > Reported-by: Larry Finger > Signed-off-by: Jaswinder Singh Rajput > --- > arch/x86/pci/acpi.c | 16 ++++++++++------ > 1 files changed, 10 insertions(+), 6 deletions(-) Ah, nice! I suspect it was this upstream commit causing it: f9cde5f: x86/ACPI: Correct maximum allowed _CRS returned resources and warn if exceeded right? Jesse, you'll handle this, right? I'll apply it to tip:out-of-tree (not-for-upstream) for testing. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/