DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=default; d=virtuousgeek.org;
	h=Received:Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References:X-Mailer:Mime-Version:Content-Type:Content-Transfer-Encoding:X-Identified-User;
	b=WeMnuFmWLXus9c2AAayhOJSaTWtrXOCiJ40w2vovH1U7ZQQc0yHXOgLov92r+xUe/c5zZYDASmvL/dBES7uCQufbW4B49EBrsDdgbgrk3/l6xr0mYLEzWhrITXM/ZGRs;
Date: Wed, 24 Jun 2009 13:04:41 -0700
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
       Justin Mattock <justinmattock@gmail.com>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       Linux PCI <linux-pci@vger.kernel.org>
Subject: Re: pci 0000:01:00.0: BAR 6: no parent found for of device
 [0xfffe0000-0xffffffff]
Message-ID: <20090624130441.1c25c40e@jbarnes-g45>
In-Reply-To: <20090624195030.GS19977@parisc-linux.org>
References: <dd18b0c30906241027u152274b1kd4c854ada4de33dd@mail.gmail.com>
	<200906242130.07583.rjw@sisk.pl>
	<20090624195030.GS19977@parisc-linux.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1638
Lines: 42

On Wed, 24 Jun 2009 13:50:30 -0600
Matthew Wilcox <matthew@wil.cx> wrote:

> On Wed, Jun 24, 2009 at 09:30:07PM +0200, Rafael J. Wysocki wrote:
> > (Adding CC to linux-pci)
> 
> Thanks Rafael.
> 
> > On Wednesday 24 June 2009, Justin Mattock wrote:
> > > (just pulled the latest git)
> > > And am seeing this:
> > 
> > Where pci 0000:01:00.0 and 0000:02:00.0 are what?
> > 
> > > [    0.696001] pci 0000:01:00.0: BAR 6: no parent found for of
> > > device [0xfffe0000-0xffffffff]
> 
> So the message is coming from pci_claim_resource, and
> if you bother to bisect, you'll track it back to my commit
> a76117dfd687ec4be0a9a05214f3009cc5f73a42 .  What's going on here,
> since this is BAR 6, is we have a ROM which has been mapped high, and
> then not unmapped.  The BAR doesn't fit in the parent's window, so
> the code is rightly declining to allocate the BAR.
> 
> Before my patch, we silently didn't allocate the BARs.  Now we print
> a message.  I wonder what to do ... we could silence this warning in
> pci_claim_resource (patch below).  Or we could declare this to be a
> bug, and fix it by disabling the ROM BAR (by clearing bit 0).
> 
> I'm agnostic ... anyone have any preferences?

Well, given that sometimes the ROM is important, it seems like an
error.  Really we should be smarter about re-allocating things as
necessary...

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/