Date: Thu, 25 Jun 2009 11:19:39 +0200
From: Andi Kleen <andi@firstfloor.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Andi Kleen <andi@firstfloor.org>,
       Andrew Morton <akpm@linux-foundation.org>, Tejun Heo <tj@kernel.org>,
       linux-kernel@vger.kernel.org, x86@kernel.org,
       linux-arch@vger.kernel.org, mingo@elte.hu, tglx@linutronix.de,
       cl@linux-foundation.org
Subject: Re: [PATCHSET] percpu: generalize first chunk allocators and improve lpage NUMA support
Message-ID: <20090625091939.GS6760@one.firstfloor.org>
References: <1245850216-31653-1-git-send-email-tj@kernel.org> <20090624165508.30b88343.akpm@linux-foundation.org> <20090625000202.GR6760@one.firstfloor.org> <4A42C131.6040007@zytor.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A42C131.6040007@zytor.com>
User-Agent: Mutt/1.4.2.2i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1386
Lines: 42

On Wed, Jun 24, 2009 at 05:13:37PM -0700, H. Peter Anvin wrote:
> Andi Kleen wrote:
> > 
> > Haven't read the new patches, but per cpu data always was sized
> > for all possible CPUs.
> > 
> >> and N is large, what did it cost?
> > 
> >> And what are reasonable values of N?
> > 
> > N should normally not be large anymore, since num_possible_cpus() 
> > is sized based on firmware information now.
> > 
> 
> *Ahem* virtual machines *ahem*...

And? Even there's not that big typically. 

The traditional problem was just for 128 NR_CPUs kernel were nothing
was sized based on machine capacity.

Also on large systems the VMs shouldn't be sized for full capacity.

> 
> I have discussed this with Tejun, and the plan is to allocate the percpu
> information when a processor is first brought online (but not removed
> when it is offlined again.)  It's a real problem for 32-bit VMs, so it's
> more important than you'd think.

You have to rewrite all code that does for_each_possible_cpu (x) 
in initialization then to use callbacks. It would be a gigantic change
all over the tree.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/