Message-ID: <4A439D7D.9030401@shipmail.org>
Date: Thu, 25 Jun 2009 17:53:33 +0200
From: =?ISO-8859-1?Q?Thomas_Hellstr=F6m?= <thomas@shipmail.org>
User-Agent: Thunderbird 2.0.0.22 (Windows/20090605)
MIME-Version: 1.0
To: Jerome Glisse <glisse@freedesktop.org>
CC: Dave Airlie <airlied@gmail.com>, linux-kernel@vger.kernel.org,
       dri-devel@lists.sf.net
Subject: Re: TTM page pool allocator
References: <1245931298.13359.8.camel@localhost.localdomain>
In-Reply-To: <1245931298.13359.8.camel@localhost.localdomain>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1389
Lines: 40

Jerome Glisse skrev:
> Hi,
>
> Thomas i attach a reworked page pool allocator based on Dave works,
> this one should be ok with ttm cache status tracking. It definitely
> helps on AGP system, now the bottleneck is in mesa vertex's dma
> allocation.
>
> Cheers,
> Jerome
>   
Hi, Jerome!
In general it looks very good. Some things that need fixing:

1)  We must have a way to hand back pages. I still not quite understand 
how the shrink callbacks work and whether they are applicable. Another 
scheme would be to free, say 1MB when we have at least 2MB available.

2) We should avoid including AGP headers if AGP is not configured. 
Either reimplement unmap_page_from_agp or map_page_into_agp or move them 
out from the AGP headers. We've hade complaints before from people with 
AGP free systems that the code doesn't compile.

3) Since we're allocating (and freeing) in batches we should use the 
set_pages_array() interface to avoid a global tlb flush per page.

4) We could now skip the ttm_tt_populate() in ttm_tt_set_caching, since 
it will always allocate cached pages and then transition them.

5) Use TTM_PFX in printouts.

/Thomas


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/