DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :cc:content-type:content-transfer-encoding;
        b=SeipakJybo6iR6X/xxX5kqQyY61GAfgrirJJhT9+KZQB51ro7St3cIK/OTHRnxGMty
         NHti1QIl3zPd+CvzbEu1PavBJTbB048Ynix/spV9bMmDI5ncmZGeONZ986jJgv6Pu6Ek
         quEAnOT9CoKs11D5JOvz3gCJx/4zA4/PZXyac=
MIME-Version: 1.0
In-Reply-To: <20090626002345.07928230@dxy.sh.intel.com>
References: <20090608152420.0e76c302@dxy.sh.intel.com>
	 <1245936693.20530.107.camel@jani-desktop>
	 <20090625220826.1fa7413e@dxy.sh.intel.com>
	 <1245941565.20530.134.camel@jani-desktop>
	 <1245942355.20530.141.camel@jani-desktop>
	 <20090625230949.53beda65@dxy.sh.intel.com>
	 <1245944528.20530.145.camel@jani-desktop>
	 <20090625234846.1b987069@dxy.sh.intel.com>
	 <1245946154.9103.742.camel@pcarmody-desktop>
	 <20090626002345.07928230@dxy.sh.intel.com>
Date: Thu, 25 Jun 2009 09:42:42 -0700
Message-ID: <d120d5000906250942j1d25f4d6rccc12034758f8815@mail.gmail.com>
Subject: Re: [PATCH]input: Change timer function to workqueue for gpio_keys 
	driver
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Alek Du <alek.du@intel.com>
Cc: "ext-phil.2.carmody@nokia.com" <ext-phil.2.carmody@nokia.com>,
       "Nikula Jani.1 (EXT-Nixu/Helsinki)" <ext-jani.1.nikula@nokia.com>,
       LKML <linux-kernel@vger.kernel.org>,
       Trilok Soni <soni.trilok@gmail.com>,
       "linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
       "ben-linux@fluff.org" <ben-linux@fluff.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1285
Lines: 32

On Thu, Jun 25, 2009 at 9:23 AM, Alek Du<alek.du@intel.com> wrote:
> On Fri, 26 Jun 2009 00:09:14 +0800
> Phil Carmody <ext-phil.2.carmody@nokia.com> wrote:
>
>> If you stopped calling the delay after the first transition "debouncing
>> time" and simply called it a "delay" you might more easily see that it
>> does *no* debouncing at all. Imagine putting noise on the line
>> constantly - the original code's timer would never expire. Your timer
>> will expire after a delay, and while the line is still toggling
>> frantically - you've not debounced.
>
> I don't know if it is really meaningful if you want to handle such pool signal...
> Ok, if you want to handle this ultimate case, will this patch work?
>
> ? ? ? ?BUG_ON(irq != gpio_to_irq(button->gpio));
>
> + ? ? ? cancel_delayed_work_sync(&bdata->work);

Can't do *_sync in interrupt context.

> ? ? ? ?delay = button->debounce_interval ?
> ? ? ? ? ? ? ? ? ? ? ? ?msecs_to_jiffies(button->debounce_interval) : 0;
> ? ? ? ?schedule_delayed_work(&bdata->work, delay);
>

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/