Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759544AbZFYTeV (ORCPT ); Thu, 25 Jun 2009 15:34:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758108AbZFYTeC (ORCPT ); Thu, 25 Jun 2009 15:34:02 -0400 Received: from brick.kernel.dk ([93.163.65.50]:47646 "EHLO kernel.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757974AbZFYTeA (ORCPT ); Thu, 25 Jun 2009 15:34:00 -0400 Date: Thu, 25 Jun 2009 21:34:02 +0200 From: Jens Axboe To: Linus Torvalds Cc: "Martin K. Petersen" , NeilBrown , Mike Snitzer , Alasdair G Kergon , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, linux-ide@vger.kernel.org, linux-fsdevel@vger.kernel.org, device-mapper development Subject: Re: [dm-devel] REQUEST for new 'topology' metrics to be moved out of the 'queue' sysfs directory. Message-ID: <20090625193402.GA31415@kernel.dk> References: <19010.62951.886231.96622@notabene.brown> <125b48b7ffc99a496fbdd512f38cada5.squirrel@neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1317 Lines: 35 On Thu, Jun 25 2009, Linus Torvalds wrote: > > > On Thu, 25 Jun 2009, Martin K. Petersen wrote: > > > > Neil> So I asked git why it as added, and it pointed to > > Neil> commit 1308835ffffe6d61ad1f48c5c381c9cc47f683ec > > > > Neil> which suggests that it was added so that user space could tell the > > Neil> kernel whether the device was rotational, rather than the other > > Neil> way around. > > > > There's an option to do it via udev for broken devices that don't report > > it. But both SCSI and ATA have a setting that gets queried and the > > queue flag set accordingly. > > .. except few devices actually set it. > > That flag is _definitely_ all about the user being able to override it. Most certainly, the idea was to add udev rules to set it for drives. Fortunately newer drives to work right without a need for such rules, but it should be handy for the ones released last year and earlier. Most user space will not care what the setting is, it's mostly for internal use. CFQ uses it, as does btrfs to decide allocation policy. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/